Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Accesible toolbar #1

Closed
wants to merge 11 commits into
from

Conversation

Projects
None yet
2 participants

No description provided.

Owner

ipeychev commented Sep 30, 2014

Just started reviewing :)

:octocat: Sent from GH.

ambrinchaudhary added some commits Sep 24, 2014

@ambrinchaudhary ambrinchaudhary Toolbars are now accesible by keyboards thanks to FocusManager
Signed-off-by: Ambrin Chaudhary <ambrin.chaudhary@liferay.com>
0c97d8d
@ambrinchaudhary ambrinchaudhary Remove autohide for triggerButton
Signed-off-by: Ambrin Chaudhary <ambrin.chaudhary@liferay.com>
f764381
@ambrinchaudhary ambrinchaudhary Remove autohide for toolbar images
Signed-off-by: Ambrin Chaudhary <ambrin.chaudhary@liferay.com>
0b55b94
@ambrinchaudhary ambrinchaudhary handle ESC key when editor is focused
Signed-off-by: Ambrin Chaudhary <ambrin.chaudhary@liferay.com>
038679f
@ambrinchaudhary ambrinchaudhary always hide before showing in order to reset styles
Signed-off-by: Ambrin Chaudhary <ambrin.chaudhary@liferay.com>
a3b888d
@ambrinchaudhary ambrinchaudhary Y.soon is not needed if we put focus properly in editor and toolbar
Signed-off-by: Ambrin Chaudhary <ambrin.chaudhary@liferay.com>
1f39705
@ambrinchaudhary ambrinchaudhary SF
Signed-off-by: Ambrin Chaudhary <ambrin.chaudhary@liferay.com>
80ca24e
@ambrinchaudhary ambrinchaudhary SF c61b33f
Owner

ipeychev commented Sep 30, 2014

Just started reviewing :)

:octocat: Sent from GH.

@ambrinchaudhary ambrinchaudhary changed the title from SF to Accesible toolbar Oct 2, 2014

Owner

ipeychev commented Oct 2, 2014

Just started reviewing :)

:octocat: Sent from GH.

Owner

ipeychev commented Oct 3, 2014

Just started reviewing :)

:octocat: Sent from GH.

Owner

ipeychev commented Oct 3, 2014

Just started reviewing :)

:octocat: Sent from GH.

@ipeychev ipeychev closed this Oct 10, 2014

@ambrinchaudhary ambrinchaudhary deleted the ambrinchaudhary:accessible_toolbars branch Dec 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment