Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Event handling for aui-toolbar children has changed #9

Closed
Robert-Frampton opened this Issue · 0 comments

1 participant

@Robert-Frampton

Currently in trunk, using the handler property on the children of aui-toolbars does not work.

toolbarChildren.push(
    {
        icon: 'add',
        label: 'button',
        handler: function(event) {
            someFunction();
        }
    }
);

Instead we are using the onClick event.

toolbarChildren.push(
    {
        icon: 'add',
        label: 'button',
        on: {
            click: function(event) {
                someFunction();
            }
        }
    }
);

When upgrading this is a hassle to change, especially if the toolbar has many children. If the UT could handle these changes it would save the developer a lot of time and possible confusion.

@ipeychev ipeychev closed this issue from a commit
@ipeychev Fix #9 Change "handler" to "on: click" for Toolbar
Since the event handling for AUI Toolbar children has changed,
so we have to replace:

handler: function(event) {
    someFunction();
}

with:

on: {
    click: function(event) {
        someFunction();
    }
}
cf4fb14
@ipeychev ipeychev closed this in cf4fb14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.