Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File (graph.go) notes description error #1570

Closed
Diomchen opened this issue Feb 14, 2022 · 2 comments
Closed

File (graph.go) notes description error #1570

Diomchen opened this issue Feb 14, 2022 · 2 comments
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization

Comments

@Diomchen
Copy link

Diomchen commented Feb 14, 2022

Describe the bug:

health graph:

cluster peers :

12D3KooWDKsuZUhBvnHf3K1bbxMoYQACgzTofEKuKvq8YfTPi52h | ubuntu | Sees 3 other peers
  > Addresses:
    - /ip4/127.0.0.1/tcp/9096/p2p/12D3KooWDKsuZUhBvnHf3K1bbxMoYQACgzTofEKuKvq8YfTPi52h
    - /ip4/192.168.14.203/tcp/9096/p2p/12D3KooWDKsuZUhBvnHf3K1bbxMoYQACgzTofEKuKvq8YfTPi52h
  > IPFS: 12D3KooWFL2iQYvCWUZ1q2jzyW2UfJDyU7KXNUku6DmKqYs1nsxL
    - /ip4/127.0.0.1/tcp/4001/p2p/12D3KooWFL2iQYvCWUZ1q2jzyW2UfJDyU7KXNUku6DmKqYs1nsxL
    - /ip4/127.0.0.1/udp/4001/quic/p2p/12D3KooWFL2iQYvCWUZ1q2jzyW2UfJDyU7KXNUku6DmKqYs1nsxL
    - /ip4/192.168.14.203/tcp/4001/p2p/12D3KooWFL2iQYvCWUZ1q2jzyW2UfJDyU7KXNUku6DmKqYs1nsxL
    - /ip4/192.168.14.203/udp/4001/quic/p2p/12D3KooWFL2iQYvCWUZ1q2jzyW2UfJDyU7KXNUku6DmKqYs1nsxL
    - /ip6/::1/tcp/4001/p2p/12D3KooWFL2iQYvCWUZ1q2jzyW2UfJDyU7KXNUku6DmKqYs1nsxL
    - /ip6/::1/udp/4001/quic/p2p/12D3KooWFL2iQYvCWUZ1q2jzyW2UfJDyU7KXNUku6DmKqYs1nsxL
12D3KooWKmokzwBmpJnRoTGGhxg6hui43CM18MEQCj2UCi4r3n59 | localhost.localdomain | Sees 3 other peers
  > Addresses:
    - /ip4/127.0.0.1/tcp/9096/p2p/12D3KooWKmokzwBmpJnRoTGGhxg6hui43CM18MEQCj2UCi4r3n59
    - /ip4/172.16.2.218/tcp/9096/p2p/12D3KooWKmokzwBmpJnRoTGGhxg6hui43CM18MEQCj2UCi4r3n59
  > IPFS: QmPp4z6gLeibywWjLqfwkrrSG77pGj7m6zfFZ6Qc3U8nZZ
    - /ip4/127.0.0.1/tcp/4001/p2p/QmPp4z6gLeibywWjLqfwkrrSG77pGj7m6zfFZ6Qc3U8nZZ
    - /ip4/127.0.0.1/udp/4001/quic/p2p/QmPp4z6gLeibywWjLqfwkrrSG77pGj7m6zfFZ6Qc3U8nZZ
    - /ip4/172.16.2.218/tcp/4001/p2p/QmPp4z6gLeibywWjLqfwkrrSG77pGj7m6zfFZ6Qc3U8nZZ
    - /ip4/172.16.2.218/udp/4001/quic/p2p/QmPp4z6gLeibywWjLqfwkrrSG77pGj7m6zfFZ6Qc3U8nZZ
    - /ip6/::1/tcp/4001/p2p/QmPp4z6gLeibywWjLqfwkrrSG77pGj7m6zfFZ6Qc3U8nZZ
    - /ip6/::1/udp/4001/quic/p2p/QmPp4z6gLeibywWjLqfwkrrSG77pGj7m6zfFZ6Qc3U8nZZ
12D3KooWMHp7q2j93LYFAn1YNABnJU3cqKs2xmbhUNdCLRcwMcNW | ubuntu | Sees 3 other peers
  > Addresses:
    - /ip4/127.0.0.1/tcp/9096/p2p/12D3KooWMHp7q2j93LYFAn1YNABnJU3cqKs2xmbhUNdCLRcwMcNW
    - /ip4/192.168.14.202/tcp/9096/p2p/12D3KooWMHp7q2j93LYFAn1YNABnJU3cqKs2xmbhUNdCLRcwMcNW
  > IPFS: 12D3KooWSv1izEAdxBC8xm51iGRvnF5rG9njpwnyBcs5P6MkRihx
    - /ip4/127.0.0.1/tcp/4001/p2p/12D3KooWSv1izEAdxBC8xm51iGRvnF5rG9njpwnyBcs5P6MkRihx
    - /ip4/127.0.0.1/udp/4001/quic/p2p/12D3KooWSv1izEAdxBC8xm51iGRvnF5rG9njpwnyBcs5P6MkRihx
    - /ip4/192.168.14.202/tcp/4001/p2p/12D3KooWSv1izEAdxBC8xm51iGRvnF5rG9njpwnyBcs5P6MkRihx
    - /ip4/192.168.14.202/udp/4001/quic/p2p/12D3KooWSv1izEAdxBC8xm51iGRvnF5rG9njpwnyBcs5P6MkRihx
    - /ip6/::1/tcp/4001/p2p/12D3KooWSv1izEAdxBC8xm51iGRvnF5rG9njpwnyBcs5P6MkRihx
    - /ip6/::1/udp/4001/quic/p2p/12D3KooWSv1izEAdxBC8xm51iGRvnF5rG9njpwnyBcs5P6MkRihx

In this code file's notes,

"IPFS nodes are rendered with gold boundaries, Cluster nodes with blue."

But with the fact of the actual generated graph, on my points , the description of the color between the IPFS node and Cluster Node is contrary.

@Diomchen Diomchen added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Feb 14, 2022
@welcome
Copy link

welcome bot commented Feb 14, 2022

Thank you for submitting your first issue to this repository! A maintainer will be here shortly to triage and review.
In the meantime, please double-check that you have provided all the necessary information to make this process easy! Any information that can help save additional round trips is useful! We currently aim to give initial feedback within two business days. If this does not happen, feel free to leave a comment.
Please keep an eye on how this issue will be labeled, as labels give an overview of priorities, assignments and additional actions requested by the maintainers:

  • "Priority" labels will show how urgent this is for the team.
  • "Status" labels will show if this is ready to be worked on, blocked, or in progress.
  • "Need" labels will indicate if additional input or analysis is required.

Finally, remember to use https://discuss.ipfs.io if you just need general support.

@Diomchen Diomchen changed the title There is one wrong point that describing wrongly the color between the IPFS Node and Cluster Node in 'graph.go'. File(graph.go notes description error Feb 14, 2022
@Diomchen Diomchen changed the title File(graph.go notes description error File (graph.go) notes description error Feb 14, 2022
hsanjuan added a commit that referenced this issue Feb 14, 2022
Fix #1570: fix comment description about graph nodes' color
@hsanjuan
Copy link
Collaborator

hsanjuan commented Feb 14, 2022

Thanks

@hsanjuan hsanjuan added this to the Release v0.14.5 milestone Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

2 participants