Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify "ipfs --api <cluster ip> pin add myfile.txt" works as expected. #224

Closed
hsanjuan opened this issue Nov 7, 2017 · 0 comments
Closed

Verify "ipfs --api <cluster ip> pin add myfile.txt" works as expected. #224

hsanjuan opened this issue Nov 7, 2017 · 0 comments
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) need/review Needs a review P1 High: Likely tackled by core team if no one steps up

Comments

@hsanjuan
Copy link
Collaborator

hsanjuan commented Nov 7, 2017

See https://discuss.ipfs.io/t/ipfs-cluster-add-file-issue/1403/5

This used to work. It's weird that progress is shown, as cluster sets it to false. Maybe something has changed in ipfs and deals with progress being missing in a different way than before.
@hsanjuan hsanjuan added kind/bug A bug in existing code (including security flaws) exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up status/ready Ready to be worked labels Nov 7, 2017
@hsanjuan hsanjuan added this to the User feedback and bugs [Q4O3] milestone Nov 7, 2017
@hsanjuan hsanjuan added status/in-progress In progress and removed status/ready Ready to be worked labels Nov 13, 2017
hsanjuan added a commit that referenced this issue Nov 13, 2017
@hsanjuan
Fix #224: Better handling of progress updates when proxy-adding file
5f70a03 
Up to know, we hardcoded progress to "false" in the proxy, regardless
of what the original request said. We now leave it as it is, and
just ignore any progress updates when processing the response.

Since the response is buffered and set back all together, they are
still useless, but at least the clients (ipfs cli) won't show a 0%
progress bar when successfully adding a file.

License: MIT
Signed-off-by: Hector Sanjuan <hector@protocol.ai>
@hsanjuan hsanjuan added need/review Needs a review and removed status/in-progress In progress labels Nov 13, 2017
@hsanjuan hsanjuan mentioned this issue Nov 14, 2017
Closed
hsanjuan added a commit that referenced this issue Nov 14, 2017
@hsanjuan
Merge pull request #231 from ipfs/fix/224-pin-progress
dc3f5b2 
Fix #224: Better handling of progress updates when proxy-adding file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) need/review Needs a review P1 High: Likely tackled by core team if no one steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hsanjuan