Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1547: Store pin metadata in a sorted array #1664

Merged
merged 2 commits into from
May 5, 2022
Merged

Fix #1547: Store pin metadata in a sorted array #1664

merged 2 commits into from
May 5, 2022

Commits on May 5, 2022

  1. Fix #1547: Store pin metadata in a sorted array 

    This deprecates the Metadata protobuf map and starts serializing metadata as an
array that is always sorted by the metadata key.

This should resolve the issue that an state export file can be imported
resulting in two different CRDT dags because the binary representation of the
pin can arbitrarily change depending on how the keys in the map are listed,
and thus the CID of a delta is impacted.

So with this, a state export should result in exactly the same DAG regardless
of where it is imported.
    @hsanjuan
    hsanjuan committed May 5, 2022
    Configuration menu
    Copy the full SHA
    5586133 View commit details
    Browse the repository at this point in the history

  2. GetMetadata: ignore linter check

    @hsanjuan
    hsanjuan committed May 5, 2022
    Configuration menu
    Copy the full SHA
    e607a41 View commit details
    Browse the repository at this point in the history