This repository was archived by the owner on Mar 10, 2020. It is now read-only.
refactor: replace wreck with raw request #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
reviewed
Nov 8, 2016
| expect(result.length).to.equal(1) | ||
| done() | ||
| }) | ||
| }) |
daviddias
reviewed
Nov 8, 2016
| function parseRaw (res, cb) { | ||
| res | ||
| .once('error', cb) | ||
| .pipe(concat((data) => cb(null, data))) |
Contributor
Author
There was a problem hiding this comment.
Because concat does the right thing for streams, arrays and buffers
Contributor
There was a problem hiding this comment.
Thank you :) Will remind me of that the next time I need to do this
daviddias
approved these changes
Nov 8, 2016
Contributor
daviddias
left a comment
daviddias
left a comment
There was a problem hiding this comment.
LGTM. Does this mean that browserify is now golden?
daviddias
reviewed
Nov 8, 2016
|
|
||
| function display (hash) { | ||
| ipfs.cat(hash, function (err, res) { | ||
| ipfs.cat(hash, {buffer: true}, function (err, res) { |
Contributor
There was a problem hiding this comment.
I still think this buffer: true is one of the most misleading features. Can you add a comment that says:
"Buffer the whole response instead of streaming it"
6 tasks
daviddias
reviewed
Nov 8, 2016
| "main": "index.js", | ||
| "scripts": { | ||
| "start": "browserify -t brfs index.js > bundle.js && http-server -a 127.0.0.1 -p 8888" | ||
| "start": "browserify index.js > bundle.js && http-server -a 127.0.0.1 -p 8888" |
Contributor
|
btw, you missed the chance of calling this brach 'reeeeekt!' ahah :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.