Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Test Suite #1121

Open
hacdias opened this issue Sep 13, 2019 · 0 comments

Comments

@hacdias
Copy link
Member

commented Sep 13, 2019

Right now, we have quite a few unit tests and some end-to-end tests for the launching process. We should aim to improve this and get a better coverage of the code.

Unit Tests

We are aiming for one unit test file per file. The biggest issue with unit tests is the amount of mocking we need to do to make sure we don't have side-effects.

E2E

We are using Spectron for our end-to-end tests and it can sometimes be limiting since we have a menubar application and Spectron does not allow to test menus.

Some interesting E2E tests that we should aim to make (if possible):

  • Test menubar interaction.
  • Test global shortcuts functionality.
  • Test adding ipfs to PATH.
  • Test Protocol Handlers (macOS and Windows only).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.