Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support libp2p >=0.29.0 #81

Closed
wants to merge 4 commits into from

Conversation

HexaField
Copy link

@HexaField HexaField commented Sep 11, 2020

Breaking changes to the way PeerID and the move from Buffers to Uint8Arrays meant this package is no longer compatible with libp2p >=v0.29.0

This PR updates ipfs-pubsub-room to support the latest libp2p, though does not include a publish-ready status.

@jacobfriedman
Copy link

jacobfriedman commented Nov 16, 2020

Bump

@straiforos
Copy link

straiforos commented Jan 2, 2021

Happy new year!

The commit messages are not formatted according to Commit Lint library standards. I am working to update this on your behalf. Or if you could update to state chore:

Copy link

@straiforos straiforos left a comment

Looks great, unfortunately the commit messages are not correct. The work passes so I am going to push this through and see if the community hates me or not. :) I want this fix in my work and would hate to redo and take credit for this amazing work. Well done @HexaField! Next time please update the commit messages to state commit lint message statuses. https://github.com/conventional-changelog/commitlint

@HexaField
Copy link
Author

HexaField commented Jan 2, 2021

You may want to check out this. Since this repo has had no action in a year I have updated this code further elsewhere. It has not been released. I can create a PR with these updates soon.

https://github.com/HexaField/js-libp2p-pubsub-room

@HexaField HexaField closed this Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants