Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add several features #12

Merged
merged 3 commits into from May 31, 2019

Conversation

Projects
None yet
3 participants
@satazor
Copy link
Member

commented May 31, 2019

  • Add identities.has()
  • Add support for gender, nationality and address in the profile
  • Add identity.profile.setProperties()

@satazor satazor requested a review from paulobmarcos May 31, 2019

@codecov-io

This comment has been minimized.

Copy link

commented May 31, 2019

Codecov Report

Merging #12 into master will decrease coverage by 1.16%.
The diff coverage is 2.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   49.22%   48.06%   -1.17%     
==========================================
  Files          24       24              
  Lines         908      932      +24     
  Branches      115      119       +4     
==========================================
+ Hits          447      448       +1     
- Misses        400      419      +19     
- Partials       61       65       +4
Impacted Files Coverage Δ
src/identities/index.js 11.39% <0%> (-0.15%) ⬇️
src/identities/identity/profile.js 12.5% <2.56%> (-1.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 343517c...1cd3c11. Read the comment docs.

@paulobmarcos paulobmarcos merged commit 921e099 into master May 31, 2019

4 of 6 checks passed

codecov/patch 2.5% of diff hit (target 49.22%)
Details
codecov/project 48.06% (-1.17%) compared to 343517c
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

satazor added a commit that referenced this pull request May 31, 2019

feat: add several features to identities, see summary (#12)
* feat: add identities.has()

* feat: add support for gender, nationality and address in the profile

* fix: forbid extraneous props in image

* feat: add identity.profile.setProperties()

@satazor satazor deleted the several-additions branch Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.