Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: locker and storage #2

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Projects
None yet
3 participants
@paulobmarcos
Copy link
Contributor

commented Mar 6, 2019

This PR aims close #11 and to:

  • Implement Storage with localStorage.
  • Implement Locks with Passphrase lock type.
  • Implement Idle Counter.
  • Implement Locker.

@paulobmarcos paulobmarcos changed the base branch from master to chore_repository-config Mar 6, 2019

@paulobmarcos paulobmarcos requested a review from satazor Mar 6, 2019

@paulobmarcos paulobmarcos force-pushed the feat_locker-and-storage branch 2 times, most recently from a19969c to 0dfbe60 Mar 6, 2019

@paulobmarcos paulobmarcos changed the base branch from chore_repository-config to master Mar 6, 2019

@paulobmarcos paulobmarcos referenced this pull request Mar 6, 2019

Closed

Implement the "locker" scope in the IDM Wallet module #11

0 of 1 task complete
Show resolved Hide resolved package.json Outdated
Show resolved Hide resolved src/locker/idle-counter.js Outdated
Show resolved Hide resolved src/locker/index.js Outdated
Show resolved Hide resolved src/locker/locks/tests/index.test.js Outdated
Show resolved Hide resolved src/locker/locks/tests/passphrase.test.js Outdated
Show resolved Hide resolved src/locker/tests/idle-counter.test.js Outdated
@satazor

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

@paulobmarcos as a reminder, we should update the SPEC document with the changes we introduced. Moreover, we need to decide if some of the methods we introduced should go into the spec or are just related to this specific implementation.

@paulobmarcos paulobmarcos force-pushed the feat_locker-and-storage branch 2 times, most recently from 61aa684 to f140dfa Mar 7, 2019

@PedroMiguelSS
Copy link

left a comment

Everything looks good to me 🤙

Show resolved Hide resolved demo/.gitignore Outdated

@paulobmarcos paulobmarcos force-pushed the feat_locker-and-storage branch from f140dfa to bccb1c4 Mar 7, 2019

@paulobmarcos paulobmarcos merged commit 4505e00 into master Mar 7, 2019

@paulobmarcos paulobmarcos deleted the feat_locker-and-storage branch Mar 7, 2019

@satazor satazor referenced this pull request Mar 11, 2019

Closed

Implement the "storage" scope in the IDM Wallet module #48

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.