Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Async lock isEnable #7

Merged
merged 9 commits into from Apr 25, 2019

Conversation

Projects
None yet
2 participants
@paulobmarcos
Copy link
Contributor

commented Apr 22, 2019

All getters are synchronous except for lock isEnable.

This PR aims to fix it and keep it consistent with the rest.

@paulobmarcos paulobmarcos requested a review from satazor Apr 22, 2019

Show resolved Hide resolved src/locker/index.js Outdated
Show resolved Hide resolved src/locker/locks/passphrase.js Outdated
Show resolved Hide resolved src/locker/locks/base.js Outdated

@paulobmarcos paulobmarcos force-pushed the fix_lock-isEnabled-sync branch from ba717c5 to edffb65 Apr 24, 2019

@paulobmarcos paulobmarcos force-pushed the fix_lock-isEnabled-sync branch from 771fa59 to 2b89d27 Apr 25, 2019

@paulobmarcos paulobmarcos merged commit e520977 into master Apr 25, 2019

@satazor satazor deleted the fix_lock-isEnabled-sync branch Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.