Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure we have a warning for passphrases with less than 0.5 #8

Merged
merged 1 commit into from Apr 29, 2019

Conversation

Projects
None yet
3 participants
@satazor
Copy link
Member

commented Apr 29, 2019

No description provided.

@satazor satazor force-pushed the ensure-warning-passphrase branch from 3fcb9ad to f558614 Apr 29, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Apr 29, 2019

Codecov Report

Merging #8 into master will decrease coverage by 0.38%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
- Coverage     100%   99.61%   -0.39%     
==========================================
  Files          14       14              
  Lines         260      261       +1     
  Branches       35       36       +1     
==========================================
  Hits          260      260              
- Misses          0        1       +1
Impacted Files Coverage Δ
src/locker/locks/util/passphrase-strength.js 90.9% <50%> (-9.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58b0472...f558614. Read the comment docs.

@dominguesgm dominguesgm merged commit b999ef0 into master Apr 29, 2019

4 of 6 checks passed

codecov/patch 50% of diff hit (target 100%)
Details
codecov/project 99.61% (-0.39%) compared to 58b0472
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@satazor satazor deleted the ensure-warning-passphrase branch Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.