bug fix: when storing large amounts of text or bytes the data would b… #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e truncated Problem was because in the generator StreamBase._gen_chunks() the second parameter in the data slice was not incremented with the offset. Because of this only the first chunk was yielded correctly.
AliabbasMerchant
approved these changes
Nov 20, 2019
|
I think @WouterGlorieux , you will have to change the base branch to master. @Alexander255 am I right? |
|
Damn, this is so stupid! Thanks alot @WouterGlorieux for finding this! I'll take care rebasing, pushing and releasing this ASAP. |
5 tasks
|
Is this fixed already in some version? Still experiencing this issue when using the |
Merged
|
Merged in #206. Sorry for the delay everybody! |
|
This is now part of 0.4.13 |
|
@Alexander255 awesome thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
…e truncated
Problem was because in the generator StreamBase._gen_chunks() the second parameter in the data slice was not incremented with the offset.
Because of this only the first chunk was yielded correctly.