Conversation
This was referenced Jun 23, 2023
hacdias
commented
Jun 23, 2023
lidel
changed the title
lidel
requested changes
Jul 14, 2023
3 tasks
hacdias
force-pushed
the
ipip-412
branch
2 times, most recently
from
July 24, 2023 09:19
6f24b0a to
c723fd2
Compare
This reverts commit 7dde477.
lidel
approved these changes
Jul 25, 2023
lidel
left a comment
lidel
left a comment
Member
There was a problem hiding this comment.
lgtm, thank you @hacdias for adding remaining tests
@laurentsenta mind taking a look if it is ok to merge & release?
We want Rhea/Saturn to be able to run these in their CI.
Co-authored-by: Laurent Senta <laurent@singulargarden.com>
laurentsenta
approved these changes
Jul 26, 2023
laurentsenta
left a comment
laurentsenta
left a comment
Contributor
There was a problem hiding this comment.
lgtm, let's not hardcode CIDs in the code without leaving notes to future maintainers!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates tests for IPIP-412. Note the following:
ipip-412branch in Kubo. Disable this before merging.dups=n, then there are no duplicates. Ifdups=y, then the blocks of the file are sent twice, by the order they show up in the DAG. This is tested withorder=dfs.order=dfs.order=unkwhere I simply check if all the CIDs are present, but not exactly since the order can be unknown. This test also doesn't check for the order in the response content type because the gateway can answer with any order they want.