Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connmgr: give peers more weight when actively participating in a session #111

Merged
merged 4 commits into from Apr 30, 2019

Conversation

@Stebalien
Copy link
Contributor

commented Apr 25, 2019

Review as individual commits, the other two commits are chores.

@ghost ghost assigned Stebalien Apr 25, 2019

@ghost ghost added the in progress label Apr 25, 2019

@Stebalien Stebalien requested a review from hannahhoward Apr 26, 2019

@hannahhoward
Copy link
Contributor

left a comment

It looks like you're submitted a fixed value for tagging, even though the tagPeer function takes a value now.

@@ -131,7 +133,7 @@ func (spm *SessionPeerManager) run(ctx context.Context) {
}
}

func (spm *SessionPeerManager) tagPeer(p peer.ID) {
func (spm *SessionPeerManager) tagPeer(p peer.ID, value int) {
spm.tagger.TagPeer(p, spm.tag, 10)

This comment has been minimized.

Copy link
@hannahhoward

hannahhoward Apr 29, 2019

Contributor

You don't appear to be using the value passed in here

@Stebalien Stebalien requested a review from hannahhoward Apr 29, 2019

@Stebalien Stebalien force-pushed the feat/improve-connmgr branch from 244ea4f to 8d74ae2 Apr 29, 2019

@Stebalien

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

@hannahhoward thanks for catching that! Fixed.

@hannahhoward hannahhoward merged commit 07ec9e8 into master Apr 30, 2019

4 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 73.77%)
Details
codecov/project Absolute coverage decreased by -0.05% but relative coverage increased by +26.22% compared to 401b87d
Details

@ghost ghost removed the in progress label Apr 30, 2019

@momack2 momack2 added this to Done in ipfs/go-ipfs May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.