Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/ipns/ instead of /dns/ #8

Closed
sixcorners opened this issue Aug 28, 2018 · 3 comments
Closed

/ipns/ instead of /dns/ #8

sixcorners opened this issue Aug 28, 2018 · 3 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@sixcorners
Copy link

sixcorners commented Aug 28, 2018 •
edited
Loading

I think the examples in the README should be /ipns/ instead of /dns/.
Does /dns/ work? When I tried to test it I don't think it worked.
@Stebalien
Copy link
Member

You're right. Mind filing a PR?

@Stebalien Stebalien added kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked labels Aug 28, 2018
@sixcorners
Copy link
Author

It looks like there is some stuff in dnslink.go mentioning /dns/. Should that be changed too?

@ghost
Copy link

ghost commented Aug 30, 2018

I am not even sure the code in this repo is used anywhere.

mentioning /dns/. Should that be changed too?

Yes /dns is definitely not a thing anymore

Stebalien added a commit that referenced this issue Oct 13, 2018
@Stebalien
Merge pull request #9 from ebastos/patch-1
6ad8ed1 
Addressed #8
@ghost ghost removed the status/ready Ready to be worked label Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @sixcorners