MakeTypedEncoder: accept results by pointer or value #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internally, we always deserialize using pointers. However, we sometimes want to deal with values *by value* instead. This makes `MakeTypedEncoder` handle both cases.
ghost
assigned 
phritz
approved these changes
Nov 2, 2018
| buf := new(bytes.Buffer) | ||
| encoder := encoderFunc(buf) | ||
|
|
||
| if err := encoder.Encode(&fooTestObj{true}); err != nil { |
There was a problem hiding this comment.
Shouldn't there be a test that passes fooTestObject by value?
There was a problem hiding this comment.
So, internally we always pass to Encode by pointer (or should, at least).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally, we always deserialize using pointers. However, we sometimes want to deal with values by value instead. This makes
MakeTypedEncoderhandle both cases.