Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use trimpath for compatibility with go-ipfs v0.7.0 #9

Merged
merged 2 commits into from Sep 22, 2020

Conversation

aschmahmann
Copy link
Contributor

@aschmahmann aschmahmann commented Sep 4, 2020

This PR changes the build flags used when building plugins.

There are 3 types of go-ipfs we support building plugins against:

  1. The release binaries distributed at dist.ipfs.io
  2. A locally built go-ipfs
  3. A Git referred version (e.g. commit/branch/tag) of go-ipfs

Previously:
Use the -asmflags=all=-trimpath="$(GOPATH)" -gcflags=all=-trimpath="$(GOPATH)" flags no matter which version of the plugin we're building against.

This was a pain when building against a Git commit/branch/tagged version of go-ipfs since the complex set of flags above had to be passed into go get github.com/ipfs/go-ipfs/cmd/ipfs@{commit|branch|tag}. Additionally, the use of GOPATH here may not be correct depending on how the users' directory structure is set up.

Now:
Use the -asmflags=all=-trimpath="$(GOPATH)" -gcflags=all=-trimpath="$(GOPATH)" only when building against a locally build copy of go-ipfs, otherwise use the -trimpath flag instead.

This means we can run go get -trimpath github.com/ipfs/go-ipfs/cmd/ipfs@{commit|branch|tag} and just build the plugin with -trimpath (as done in the Makefile here) and things will work.

@welcome
Copy link

welcome bot commented Sep 4, 2020

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@aschmahmann
Copy link
Contributor Author

@Stebalien updated, take a look when you get a chance 🙏

@aschmahmann aschmahmann mentioned this pull request Sep 22, 2020
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants