Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
`ipfs p2p` feedback thread #3994
For everyone trying out the
To enable the command, you will need to run:
Basic usage of
On the other ipfs node, connect to the listener on node A
What changed: #3994 (comment)
Unfortunately no, you could set up the listeners from the browser, but you couldn't actually connect to it since you can't dial TCP connections there. Unless... @magik6k could you specify a /ws multiaddr for the listeners?…
On Wed, Jun 28, 2017, 05:22 ReisenB ***@***.***> wrote: Is this planned to be accessible through the browser with js-ipfs-api? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3994 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABL4HDTg_Rqp6Rg4nUp69-AhryuOL3O2ks5sIhs8gaJpZM4N-zsb> .
I'd need to look into how websockets are currently handled in go-ipfs. For dialing this should be relatively simple to do, though listen mode would probably have to use some sort of stream muxer that has js implementation. This should fit quite well into the existing code.
No opening port 10101, is that right?
liu@nas:~/ipfs/go-ipfs % ./ipfs p2p listener open p2p-test /ip4/127.0.0.1/tcp/10101
liu@nas:~/ipfs/go-ipfs % ./ipfs p2p listener ls
liu@nas:~/ipfs/go-ipfs % netstat -an | grep 10101
referenced this issue
Sep 5, 2017
And adding up to my previous comment, I noticed a different behavior between the listener and the streamer.
Considering the case in which you start a listener for the protocol
Now, with this setup, no matter if the streamer will disconnect or if the service on port 80 on
The streamer instead dies after whatever client running on
Maybe it's expected, but it would be nice to have the streamer keep listening for more than one connection, or at least having a parameter (like a sort of
#4929 includes api-breaking changes, it will likely be released with the new version of go-ipfs.
EDIT: This changed a bit while the PR was open, this is the current version:
With #4929 you will be able to pass streams to udp services. You still won't be able to listen for udp connections as local listener uses go-multiaddr-net.Listen directly, and it only supports listening on tcp now.
There are some problems with supporting udp properly:
@DavidHuie We're definitely open to having the community help there. It's something that will be tricky to get right, adding a message oriented layer to libp2p won't be trivial. If you want to get the ball rolling, open an issue in libp2p/libp2p about it, describe use cases, and tag people. We can start to brainstorm thoughts there.
I know that @lgierth was planning on working on that soon, he's out on vacation for another week or so. When he gets back maybe you two can work on pushing that?