Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop GX Support #6108

Closed
Stebalien opened this issue Mar 20, 2019 · 1 comment

Comments

Projects
1 participant
@Stebalien
Copy link
Contributor

commented Mar 20, 2019

Now that we've converted over to go modules, we need to drop GX. Unfortunately, we need to do this sooner rather than later:

  1. We have no tooling for pulling through both gx and go mod updates. We're making mistakes left and right and there's no way we can keep these versions in sync.
  2. gx-workspace won't pull through go module updates for us so we can't use it.
  3. go-libp2p is now completely out of sync so gx/go-modules will give different results.

Considerations:

  • Downstream consumers: I expect most downstream consumers will be happy to switch but it may take some work. For example, we'd like to wait for Filecoin to switch over.
  • Gx "replacement": That is, we'd like some way to retrieve go modules from ipfs.

Even with these considerations, I'd like to propose switching over immediately. Supporting both systems is a major pain and we're failing at it anyways.

@Stebalien

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

I've gotten sign-offs from both the go-ipfs and go-libp2p teams. Plan:

  1. Stop updating package.json files immediately.
  2. April 8th, remove the package.json files after consulting with downstream packages.

@Stebalien Stebalien closed this Apr 25, 2019

@momack2 momack2 added this to Done in ipfs/go-ipfs May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.