docker: simplify git ref resolution, thanks @chriscool #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| # This saves us quite a bit of image size. | ||
| && ref=$(cat .git/HEAD | grep ref | cut -d' ' -f2) \ | ||
| && commit=$(if [ -z "$ref" ]; then cat .git/HEAD; else cat ".git/$ref"; fi | head -c 7) \ | ||
| && mkdir .git/objects && commit=$(git rev-parse HEAD | head -c 7) \ |
There was a problem hiding this comment.
Why don't you use git rev-parse --short HEAD instead of git rev-parse HEAD | head -c 7?
There is the following about --short in the git rev-parse documentation:
--short
--short=number
Instead of outputting the full SHA-1 values of object names try to abbreviate them to a shorter unique name. When no length is specified 7 is used. The minimum length is 4.
so it does the right thing by default. It prints a 7 character long name. (See: https://git-scm.com/docs/git-rev-parse/2.8.3)
There was a problem hiding this comment.
Great point, thanks! Changed to --short.
Kubuxu
added
need/author-input
ghost
force-pushed
the
fix-dockerfile-currentcommit
branch
from
772b189
to
4a21f31
Compare
License: MIT Signed-off-by: Lars Gierth <larsg@systemli.org>
ghost
force-pushed
the
fix-dockerfile-currentcommit
branch
from
4a21f31
to
0eed330
Compare
|
It looks great to me now! |
Kubuxu
added
RFM
and removed
need/author-input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rev-parsesimply needed.git/packed-refsand an empty.git/objects/directory.