New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding documentation that PubSub Sub can be encoded. #3909

Merged
merged 1 commit into from May 15, 2017

Conversation

Projects
None yet
3 participants
@TUSF
Contributor

TUSF commented May 9, 2017

Turns out, the Message will Marshal properly. I tested XML and Protobufs, but doesn't seem the "marshaller" is there. I'm still not familiar enough with the codebase to go poking around, so I'm just adding a bit of documentation that was missed, and is in my opinion pretty useful.

@Kubuxu

This comment has been minimized.

Member

Kubuxu commented May 9, 2017

We should probably add info about this flag to ipfs help text itself. As it is global option for all commands.

Turns out, the Message will Marshal properly.
License: MIT
Signed-off-by: Jeremia Dominguez <ragef33@gmail.com>
@whyrusleeping

LGTM, thanks!

@whyrusleeping whyrusleeping merged commit d698380 into ipfs:master May 15, 2017

5 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
ci/circleci Your tests passed on CircleCI!
Details
codeclimate no new or fixed issues
Details
codecov/patch Coverage not affected when comparing a6e96e6...43b0b17
Details
codecov/project 62.9% (+0.3%) compared to a6e96e6
Details
commit-message-check/gitcop All commit messages are valid
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment