New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 'ipfs diag net' from codebase #3916

Merged
merged 1 commit into from May 12, 2017

Conversation

Projects
None yet
3 participants
@whyrusleeping
Member

whyrusleeping commented May 11, 2017

Been noticing quite a large amount of traffic from this lately. It seems people are using it more than intended and causing excess load on the system. That means its time to pull it out. Goodbye old friend

License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com

@Kubuxu

Kubuxu approved these changes May 11, 2017

It would be best to offer some sort of replacement for it but it it causes considerable I am ok will pull it out now and considering alternative approach.

@lgierth

This comment has been minimized.

Member

lgierth commented May 11, 2017

I'm okay removing it too -- tests need fixing

remove 'ipfs diag net' from codebase
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>

@whyrusleeping whyrusleeping merged commit 4e1d966 into master May 12, 2017

7 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci Your tests passed on CircleCI!
Details
codeclimate 26 fixed issues
Details
codecov/patch Coverage not affected when comparing a6e96e6...1cddf67
Details
codecov/project 63.95% (+1.35%) compared to a6e96e6
Details
commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@whyrusleeping whyrusleeping deleted the rm/diag-net branch May 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment