New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to dht code with provide announce option #3928

Merged
merged 1 commit into from May 25, 2017

Conversation

Projects
None yet
2 participants
@whyrusleeping
Member

whyrusleeping commented May 17, 2017

This PR updates the dht dependency to one that gives us the option of whether or not to actually broadcast to the network with each call to provide. The option is set to 'true' in all options, retaining the current behaviour of ipfs.

Further integration will need to be done to make proper use of this. My current thought it to have all calls by bitswap provide with no announcement, then in each command that currently pulls and provides content (add, refs, pin, etc) we have an option, default true, that recursively provides the content after the operation has completed.

License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com

update to dht code with provide announce option
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
@Kubuxu

Kubuxu approved these changes May 24, 2017

@whyrusleeping whyrusleeping merged commit 4cf046c into master May 25, 2017

6 of 8 checks passed

codecov/patch 30.76% of diff hit (target 63.89%)
Details
codecov/project 63.86% (-0.03%) compared to 27ebaab
Details
ci/circleci Your tests passed on CircleCI!
Details
codeclimate 1 fixed issue
Details
commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@whyrusleeping whyrusleeping deleted the feat/provide-ann-opt branch May 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment