New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make odds of 'process added after close' panic less likely #3940

Merged
merged 1 commit into from May 25, 2017

Conversation

Projects
None yet
2 participants
@whyrusleeping
Copy link
Member

whyrusleeping commented May 24, 2017

Theres still a very small chance it could happen, but this makes it much much less likely.

License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com

make odds of 'process added after close' panic less likely
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
@Kubuxu

This comment has been minimized.

Copy link
Member

Kubuxu commented May 24, 2017

Feels like an bandaid (the proper solution would be not to panic there and return error) but LGTM.

@whyrusleeping

This comment has been minimized.

Copy link
Member

whyrusleeping commented May 24, 2017

@Kubuxu yeah... its a bandaid. I don't feel like attempting to redesign goprocess right now though

It probably does make sense to have Go return an error.

@whyrusleeping whyrusleeping merged commit a6bb83b into master May 25, 2017

6 of 9 checks passed

codecov/patch 50% of diff hit (target 64.04%)
Details
codecov/project 63.84% (-0.21%) compared to ec43fe4
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
ci/circleci Your tests passed on CircleCI!
Details
codeclimate no new or fixed issues
Details
commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@whyrusleeping whyrusleeping deleted the fix/http-proc-panic branch May 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment