New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: expose port 8081 for /ws listener #3954

Merged
merged 1 commit into from Jun 10, 2017

Conversation

Projects
None yet
2 participants
@lgierth
Member

lgierth commented Jun 2, 2017

Opening this again because it's been a reality in ipfs/infrastructure for a while.

Yes, the /ws listener is soon gonna be part of the gateway and a dedicated port no longer neccessary, but until then the lack of this exposed port is a pain.

docker: expose port 8081 for /ws listener
License: MIT
Signed-off-by: Lars Gierth <larsg@systemli.org>
@whyrusleeping

This comment has been minimized.

Member

whyrusleeping commented Jun 10, 2017

LGTM, youre the dockerfile overlord.

@whyrusleeping whyrusleeping merged commit 3b04599 into master Jun 10, 2017

7 of 8 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 20dae52...edbb42b
Details
codecov/project 63.36% (+27.97%) compared to 20dae52
Details
commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@whyrusleeping whyrusleeping deleted the feat/docker-ws branch Jun 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment