New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add QUIC support #5350

Merged
merged 5 commits into from Aug 31, 2018

Conversation

Projects
None yet
4 participants
@marten-seemann
Contributor

marten-seemann commented Aug 7, 2018

Fixes #5343.

@marten-seemann marten-seemann requested a review from Kubuxu as a code owner Aug 7, 2018

- [ ] The IETF QUIC specification needs to be finalised.
- [ ] Make sure QUIC connections work reliably
- [ ] Make sure QUIC connection offer equal or better performance than TCP connections on real world networks

This comment has been minimized.

@Stebalien

Stebalien Aug 13, 2018

Contributor

Finalize libp2p-TLS handshake spec.

@Stebalien

Stebalien Aug 13, 2018

Contributor

Finalize libp2p-TLS handshake spec.

This comment has been minimized.

@marten-seemann

marten-seemann Aug 14, 2018

Contributor

Done.

@marten-seemann

marten-seemann Aug 14, 2018

Contributor

Done.

@Stebalien Stebalien added the blocked label Aug 15, 2018

@Stebalien

This comment has been minimized.

Show comment
Hide comment
@Stebalien

Stebalien Aug 15, 2018

Contributor

This is blocked, right?

Contributor

Stebalien commented Aug 15, 2018

This is blocked, right?

@marten-seemann

This comment has been minimized.

Show comment
Hide comment
@marten-seemann

marten-seemann Aug 16, 2018

Contributor

Yes, we need to merge a few gx publishes.

Contributor

marten-seemann commented Aug 16, 2018

Yes, we need to merge a few gx publishes.

@marten-seemann

This comment has been minimized.

Show comment
Hide comment
@marten-seemann

marten-seemann Aug 26, 2018

Contributor

@Stebalien, @Kubuxu: This PR is ready for merging now. Please merge ipfs/go-ipfs-config#4 before.

Contributor

marten-seemann commented Aug 26, 2018

@Stebalien, @Kubuxu: This PR is ready for merging now. Please merge ipfs/go-ipfs-config#4 before.

@wafflebot wafflebot bot added the in progress label Aug 26, 2018

@Stebalien Stebalien added RFM and removed blocked in progress labels Aug 26, 2018

@magik6k

Would be nice to get a sharness test or two, other than that looks good

@marten-seemann

This comment has been minimized.

Show comment
Hide comment
@marten-seemann

marten-seemann Aug 26, 2018

Contributor

@magik6k: Thanks for the hint. I wasn't aware of the sharness tests before. This is exactly the kind of test we should have to test that we don't accidentally break QUIC support in the future.
I added a test case performing a ping using QUIC. Please have another look.

Contributor

marten-seemann commented Aug 26, 2018

@magik6k: Thanks for the hint. I wasn't aware of the sharness tests before. This is exactly the kind of test we should have to test that we don't accidentally break QUIC support in the future.
I added a test case performing a ping using QUIC. Please have another look.

@Stebalien Stebalien added needs review and removed RFM labels Aug 26, 2018

@Stebalien

This comment has been minimized.

Show comment
Hide comment
@Stebalien

Stebalien Aug 26, 2018

Contributor

@marten-seemann looks like one of the tests is hanging.

Contributor

Stebalien commented Aug 26, 2018

@marten-seemann looks like one of the tests is hanging.

@Stebalien

This comment has been minimized.

Show comment
Hide comment
@Stebalien

Stebalien Aug 26, 2018

Contributor

Actually, it would be kind of nice to have a "twonode" test. Just add a variant that uses quic to the twonode sharness test.

Contributor

Stebalien commented Aug 26, 2018

Actually, it would be kind of nice to have a "twonode" test. Just add a variant that uses quic to the twonode sharness test.

@marten-seemann

This comment has been minimized.

Show comment
Hide comment
@marten-seemann

marten-seemann Aug 27, 2018

Contributor

@Stebalien: I just added a copy of the two-node test that uses QUIC. PHAL.

Note that this test is currently failing, which is due to this bug in quic-go: lucas-clemente/quic-go#1499. I'll cherry-pick the fix for this issue once it is reviewed, and bubble up the fix through gx.

Contributor

marten-seemann commented Aug 27, 2018

@Stebalien: I just added a copy of the two-node test that uses QUIC. PHAL.

Note that this test is currently failing, which is due to this bug in quic-go: lucas-clemente/quic-go#1499. I'll cherry-pick the fix for this issue once it is reviewed, and bubble up the fix through gx.

@Stebalien Stebalien added the blocked label Aug 27, 2018

@marten-seemann

This comment has been minimized.

Show comment
Hide comment
@marten-seemann

marten-seemann Aug 28, 2018

Contributor

I rebased everything to include the current version of quic-go.
Tests are failing because now there's a gx version mismatch of go-libp2p-transport. Looks like we need to update that one first here...

Contributor

marten-seemann commented Aug 28, 2018

I rebased everything to include the current version of quic-go.
Tests are failing because now there's a gx version mismatch of go-libp2p-transport. Looks like we need to update that one first here...

@Stebalien

This comment has been minimized.

Show comment
Hide comment
@Stebalien

Stebalien Aug 28, 2018

Contributor

I'll do that once merge some stuff (keep needing to rebase PRs).

Contributor

Stebalien commented Aug 28, 2018

I'll do that once merge some stuff (keep needing to rebase PRs).

marten-seemann added some commits Aug 7, 2018

add QUIC support
License: MIT
Signed-off-by: Marten Seemann <martenseemann@gmail.com>
update go-ipfs-config to version 0.2.5
License: MIT
Signed-off-by: Marten Seemann <martenseemann@gmail.com>
@marten-seemann

This comment has been minimized.

Show comment
Hide comment
@marten-seemann

marten-seemann Aug 29, 2018

Contributor

@Kubuxu: Can you review this please? This should be ready for merge now.

Contributor

marten-seemann commented Aug 29, 2018

@Kubuxu: Can you review this please? This should be ready for merge now.

@bigs

This comment has been minimized.

Show comment
Hide comment
@bigs

bigs Aug 29, 2018

gx renders aside, this change looks good to me.

bigs commented Aug 29, 2018

gx renders aside, this change looks good to me.

@wafflebot wafflebot bot added the in progress label Aug 30, 2018

@Stebalien

This comment has been minimized.

Show comment
Hide comment
@Stebalien

Stebalien Aug 30, 2018

Contributor

gx update bonanza done.

Contributor

Stebalien commented Aug 30, 2018

gx update bonanza done.

@Stebalien

This comment has been minimized.

Show comment
Hide comment
@Stebalien

Stebalien Aug 30, 2018

Contributor

I need to pull through a multistream update to get this to work.

Contributor

Stebalien commented Aug 30, 2018

I need to pull through a multistream update to get this to work.

marten-seemann and others added some commits Aug 26, 2018

add a QUIC sharness test
License: MIT
Signed-off-by: Marten Seemann <martenseemann@gmail.com>
add a QUIC twonode sharness test
License: MIT
Signed-off-by: Marten Seemann <martenseemann@gmail.com>
gx update deps
License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@magik6k

This comment has been minimized.

Show comment
Hide comment
@magik6k

magik6k Aug 31, 2018

Member

ci seems unhappy about deps

Member

magik6k commented Aug 31, 2018

ci seems unhappy about deps

@Stebalien

This comment has been minimized.

Show comment
Hide comment
@Stebalien

Stebalien Aug 31, 2018

Contributor

ci seems unhappy about deps

It keeps complaining about not being able to fetch deps it really should be able to fetch.

Contributor

Stebalien commented Aug 31, 2018

ci seems unhappy about deps

It keeps complaining about not being able to fetch deps it really should be able to fetch.

@Stebalien Stebalien merged commit 1b4972b into ipfs:master Aug 31, 2018

7 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codecov/patch 100% of diff hit (target 57.12%)
Details
codecov/project 57.18% (+0.06%) compared to 9a21a8c
Details
commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Aug 31, 2018

@Stebalien

This comment has been minimized.

Show comment
Hide comment
@Stebalien

Stebalien Aug 31, 2018

Contributor

We have liftoff!

🎉 🚀 🎉

Contributor

Stebalien commented Aug 31, 2018

We have liftoff!

🎉 🚀 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment