Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Really run as non-root user in docker container" #6040

Merged
merged 1 commit into from Mar 4, 2019

Conversation

@hsanjuan
Copy link
Contributor

commented Mar 3, 2019

Reverts #5048 (see discussion there).

@hsanjuan hsanjuan self-assigned this Mar 3, 2019

@hsanjuan hsanjuan requested a review from Kubuxu as a code owner Mar 3, 2019

@GitCop

This comment has been minimized.

Copy link

commented on 9f74e12 Mar 3, 2019

There were the following issues with your Pull Request

We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity.
git commit --amend can often help you quickly improve the commit message.
Guidelines and a script are available to help in the long run.
Your feedback on GitCop is welcome on this issue.


This message was auto-generated by https://gitcop.com

@ghost ghost added the in progress label Mar 3, 2019

@Stebalien
Copy link
Contributor

left a comment

Damn. I thought docker was smarter than that.

@Stebalien Stebalien merged commit e767ec4 into master Mar 4, 2019

5 of 8 checks passed

Travis CI - Branch Build Errored
Details
Travis CI - Pull Request Build Errored
Details
commit-message-check/gitcop Some commit messages are invalid
Details
ci/circleci: gotest Your tests passed on CircleCI!
Details
ci/circleci: sharness Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codecov/patch Coverage not affected when comparing 71d7cf7...9f74e12
Details
codecov/project 61.99% (-0.03%) compared to 71d7cf7
Details

@ghost ghost removed the in progress label Mar 4, 2019

@Stebalien Stebalien deleted the revert-5048-docker-non-root branch Mar 4, 2019

@Stebalien

This comment has been minimized.

Copy link
Contributor

commented Mar 4, 2019

Thanks for catching this!

geigerzaehler added a commit to oscoin/ipfs-test-network-container that referenced this pull request Mar 15, 2019
Run container as root
Since the container uses volumes the user the container is running under
needs write access to these volumes. This must be configured from the
outside and maybe complicated.

See ipfs/go-ipfs#6040 and ipfs/go-ipfs#5048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.