Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-ds-badger #6461

Merged
merged 1 commit into from Jun 21, 2019

Conversation

Projects
None yet
2 participants
@Kubuxu
Copy link
Member

commented Jun 21, 2019

License: MIT

@Kubuxu

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2019

@Stebalien badger team removed rc/branch we were depending upon.

@Kubuxu Kubuxu requested a review from Stebalien Jun 21, 2019

@Kubuxu

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2019

I had to update go-libp2p-peerstore to use also new version because version numbers of badger we completely messed up but this pulled in go-libp2p-core@v0.0.4 which is WIP. That is why we have a replace directive.

@Kubuxu

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2019

Resolves #6461

@Kubuxu Kubuxu force-pushed the fix/update-badger branch from 79459eb to 90252f8 Jun 21, 2019

Update go-ds-badger
Use replace to require go-libp2p-core@0.0.3
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>

@Kubuxu Kubuxu force-pushed the fix/update-badger branch from 90252f8 to a7f8d69 Jun 21, 2019

@Kubuxu Kubuxu merged commit 810cb60 into master Jun 21, 2019

7 of 9 checks passed

codecov/project 17.33% (-46.53%) compared to 00c1578
Details
ci/circleci: interop CircleCI is running your tests
Details
ci/circleci: build-interop Your tests passed on CircleCI!
Details
ci/circleci: gobuild Your tests passed on CircleCI!
Details
ci/circleci: golint Your tests passed on CircleCI!
Details
ci/circleci: gotest Your tests passed on CircleCI!
Details
ci/circleci: sharness Your tests passed on CircleCI!
Details
codeclimate All good!
Details
codecov/patch Coverage not affected when comparing 00c1578...a7f8d69
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.