feat: add provider shuffle option to HTTPGatewayRouter - #772
Merged
Conversation
Contributor
Author
|
Friendly ping @SgtPooki @achingbrain 🧁 👀 |
SgtPooki
reviewed
Apr 15, 2025
SgtPooki
left a comment
SgtPooki
left a comment
Member
There was a problem hiding this comment.
code looks fine to me.. i think the option could have a better name
|
|
||
| export interface HTTPGatewayRouterInit { | ||
| gateways?: Array<URL | string> | ||
| skipProviderShuffle?: boolean |
Member
There was a problem hiding this comment.
maybe something more explicit like keepOrder would be better?
Member
There was a problem hiding this comment.
also, we should probably add a jsdoc with @default tag..
Member
There was a problem hiding this comment.
Or even more concise - ‘shuffle’ (default: true)?
Contributor
Author
There was a problem hiding this comment.
@SgtPooki @achingbrain Thanks for the review!
Just pushed a commit changing it to shuffle, flipped the corresponding logic, and added a jsdoc comment with a @default tag ✔️
SgtPooki
approved these changes
Apr 16, 2025
SgtPooki
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: allow opting out of provider shuffle in HTTPGatewayRouter
See #771 for motivation.
Description
For use cases where gateway lookup order is important, this PR allows passing a new config param to
HTTPGatewayRouterwhich opts out of the shuffling which happens on each call tofindProviders.Notes & open questions
I.e., the feature is backward-compatible.
Change checklist