Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

circuit interop - browser-browser-go failing #16

Closed
dryajov opened this issue Mar 7, 2018 · 8 comments · Fixed by #64
Closed

circuit interop - browser-browser-go failing #16

dryajov opened this issue Mar 7, 2018 · 8 comments · Fixed by #64
Assignees

Comments

@dryajov
Copy link
Member

dryajov commented Mar 7, 2018

When connection to a go node over a browser relay from another browser node, the relay fails. The two browser nodes are connected over websocket-star.

cc @vyzo

@dryajov
Copy link
Member Author

dryajov commented Mar 7, 2018

Here is a pcap capture from the establish relay step - browser-browser-go.pcapng.zip. It has secio disabled so should be plain text.

@daviddias
Copy link
Member

Was this fixed with libp2p/go-libp2p-circuit#30 ?

@dryajov
Copy link
Member Author

dryajov commented Mar 15, 2018

Yep, it's taken care of there, but it's not going to be released until later, so perhaps it's worth keeping this around to track when that fix is finally released?

@daviddias
Copy link
Member

@Stebalien refresh my memory, were the mplex + circuit relay fixes released with 0.4.15?

@Stebalien
Copy link
Member

No, they're in the latest master.

daviddias added a commit that referenced this issue Jul 12, 2018
based on #16 (comment), we need 0.4.16
@daviddias
Copy link
Member

One daaaaaaay 🎶

@Stebalien
Copy link
Member

@dryajov this appears to work. Has this been fixed?

@Stebalien
Copy link
Member

Nevermind...

@ghost ghost assigned jacobheun Apr 16, 2019
@ghost ghost added the status/in-progress In progress label Apr 16, 2019
@ghost ghost removed the status/in-progress In progress label Apr 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants