Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 on deleting a pin that isn't part of pinset #854

Merged
merged 2 commits into from Jul 29, 2019

Conversation

@kishansagathiya
Copy link
Member

commented Jul 25, 2019

With this commit

  • If cid in DELETE /pins/{cid} isn't part of the pinset, it would
    return 404
  • If path in DELETE /pins/{keyType}/{path} resolves to a cid that
    isn't part of the pinset, it would return 404

Fixes #742

With this commit
- If cid in `DELETE /pins/{cid}` isn't part of the pinset, it would
return 404
- If path in `DELETE /pins/{keyType}/{path}` resolves to a cid that
isn't part of the pinset, it would return 404

License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
@kishansagathiya kishansagathiya requested a review from hsanjuan Jul 25, 2019
Copy link
Collaborator

left a comment

almost ready

api/rest/restapi_test.go Outdated Show resolved Hide resolved
api/rest/restapi_test.go Outdated Show resolved Hide resolved
License: MIT
Signed-off-by: Kishan Mohanbhai Sagathiya <kishansagathiya@gmail.com>
@kishansagathiya kishansagathiya requested a review from hsanjuan Jul 25, 2019
@hsanjuan

This comment has been minimized.

Copy link
Collaborator

commented Jul 25, 2019

Can you retrigger tests until they pass?

@kishansagathiya

This comment has been minimized.

Copy link
Member Author

commented Jul 29, 2019

This should be good now. Can't do anything about codeclimate.

@hsanjuan hsanjuan merged commit c0b8301 into master Jul 29, 2019
1 of 2 checks passed
1 of 2 checks passed
Travis CI - Branch Build Failed
Details
Travis CI - Pull Request Build Passed
Details
@hsanjuan hsanjuan deleted the issue_742 branch Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.