Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #853: Make a more orderly shutdown of rest api libp2p host #855

Merged
merged 1 commit into from Jul 26, 2019

Conversation

@hsanjuan
Copy link
Collaborator

commented Jul 25, 2019

Cancelling its context before closing the listeners and de-registering
protocols is ground for panics on libp2p.

#853

@hsanjuan hsanjuan requested a review from kishansagathiya Jul 25, 2019
@hsanjuan hsanjuan self-assigned this Jul 25, 2019
This was referenced Jul 25, 2019
api/rest/restapi.go Show resolved Hide resolved
api/rest/restapi.go Outdated Show resolved Hide resolved
Cancelling its context before closing the listeners and de-registering
protocols is ground for panics on libp2p.
@hsanjuan hsanjuan force-pushed the fix/853-rest-close-panic branch from a017772 to cf5ce49 Jul 26, 2019
@hsanjuan hsanjuan merged commit 7a78620 into master Jul 26, 2019
0 of 2 checks passed
0 of 2 checks passed
Travis CI - Branch Build Errored
Details
Travis CI - Pull Request Build Errored
Details
@hsanjuan hsanjuan deleted the fix/853-rest-close-panic branch Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.