Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use string flag instead of string slice #876

Merged
merged 1 commit into from Aug 12, 2019

Conversation

@kishansagathiya
Copy link
Member

commented Aug 11, 2019

Because string slice is not very user friendly. Using string instead
would allow us to pass a comma separated list of arguments in one option

Fixes #841

@kishansagathiya kishansagathiya requested a review from hsanjuan Aug 11, 2019
@kishansagathiya

This comment has been minimized.

Copy link
Member Author

commented Aug 11, 2019

All tests passed on first attempt!

No more flaky tests 🎉

cmd/ipfs-cluster-ctl/main.go Outdated Show resolved Hide resolved
cmd/ipfs-cluster-service/daemon.go Outdated Show resolved Hide resolved
cmd/ipfs-cluster-service/daemon.go Outdated Show resolved Hide resolved
Because string slice is not very user friendly. Using string instead
would allow us to pass a comma separated list of arguments in one option
@hsanjuan hsanjuan force-pushed the fix/stringsliceflag branch from b0fde48 to 684f588 Aug 12, 2019
@hsanjuan hsanjuan merged commit 25d0ec0 into master Aug 12, 2019
4 checks passed
4 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch Coverage not affected when comparing e614d2e...684f588
Details
codecov/project 69.03% remains the same compared to e614d2e
Details
@hsanjuan hsanjuan deleted the fix/stringsliceflag branch Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.