Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve IPNS docs #1258

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Improve IPNS docs #1258

wants to merge 22 commits into from

Conversation

2color
Copy link
Member

@2color 2color commented Aug 24, 2022

Context

This is a significant rewrite of the IPNS docs addressing many of the repeated questions while providing an overview of the tradeoffs.

#1236

Preview

https://deploy-preview-1258--neon-choux-85b010.netlify.app/concepts/ipns/

@netlify
Copy link

netlify bot commented Aug 24, 2022

Deploy Preview for neon-choux-85b010 ready!

Name Link
🔨 Latest commit 6288fee
🔍 Latest deploy log https://app.netlify.com/sites/neon-choux-85b010/deploys/6316339990e802000905789a
😎 Deploy Preview https://deploy-preview-1258--neon-choux-85b010.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

2color added 2 commits Aug 29, 2022
* origin:
  Update peering-with-content-providers.md (#1235)
  rephrase quote
  fix: typo and image position
  Adds plausible analytics to IPFS docs.
  Address feedback from Fabien
  Address feedback
  Apply suggestions from code review
  Automatically optimized images [ci skip].
  Add snapshot case study to sidebar and concepts page
  Add Snapshot to usage ideas and examples
  Add Snapshot case study
@2color 2color marked this pull request as ready for review Aug 29, 2022
@2color 2color requested a review from lidel Aug 29, 2022
@2color 2color requested a review from aschmahmann Aug 30, 2022
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
2color and others added 7 commits Sep 1, 2022
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
* origin/fix-netlify:
  fix build configuration
  Change publish folder
  Install deps
  Add netlify build
Copy link
Collaborator

@mishmosh mishmosh left a comment

Very nice. If there are any case studies or project codebases that nicely illustrate the tradeoffs you cover in the second half of this article, it might be nice to list examples.

Approving since my comments and suggestions are all non-blocking.

docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
Co-authored-by: Mosh <1306020+mishmosh@users.noreply.github.com>
lidel
lidel approved these changes Sep 2, 2022
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
docs/concepts/ipns.md Outdated Show resolved Hide resolved
@DannyS03 DannyS03 added the need/author-input Needs input from the original author label Sep 4, 2022
Co-authored-by: Marcin Rataj <lidel@lidel.org>
@filecorgi
Copy link
Contributor

filecorgi commented Sep 5, 2022

  • Image optimization came back clean!
  • Vuepress build was successful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/author-input Needs input from the original author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants