New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve IPNS docs #1258
Open
2color
wants to merge
22
commits into
main
Choose a base branch
from
improve-ipns-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve IPNS docs #1258
+186
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Name | Link |
|---|---|
| 6288fee | |
| https://app.netlify.com/sites/neon-choux-85b010/deploys/6316339990e802000905789a | |
| https://deploy-preview-1258--neon-choux-85b010.netlify.app | |
To edit notification comments on pull requests, go to your Netlify site settings.
* origin: Update peering-with-content-providers.md (#1235) rephrase quote fix: typo and image position Adds plausible analytics to IPFS docs. Address feedback from Fabien Address feedback Apply suggestions from code review Automatically optimized images [ci skip]. Add snapshot case study to sidebar and concepts page Add Snapshot to usage ideas and examples Add Snapshot case study
lidel
reviewed
Aug 30, 2022
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
* origin/fix-netlify: fix build configuration Change publish folder Install deps Add netlify build
mishmosh
approved these changes
Sep 2, 2022
Very nice. If there are any case studies or project codebases that nicely illustrate the tradeoffs you cover in the second half of this article, it might be nice to list examples.
Approving since my comments and suggestions are all non-blocking.
Co-authored-by: Mosh <1306020+mishmosh@users.noreply.github.com>
lidel
approved these changes
Sep 2, 2022
Co-authored-by: Marcin Rataj <lidel@lidel.org>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Context
This is a significant rewrite of the IPNS docs addressing many of the repeated questions while providing an overview of the tradeoffs.
#1236
Preview
https://deploy-preview-1258--neon-choux-85b010.netlify.app/concepts/ipns/