Skip to content

Conversation

@2color
Copy link
Member

@2color 2color commented Jan 31, 2023

This adds an embed of Codesandbox to the CID concepts


The [`multiformats` npm package](https://www.npmjs.com/package/multiformats) can be used to convert between CID versions, base representations, and access the binary representation:

<iframe src="https://codesandbox.io/embed/working-with-cids-xrvqop?autoresize=1&fontsize=14&hidenavigation=1&theme=dark"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including dependency on external service that may dissapear at any time is a bit brittle 👎

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you referring to https://codesandbox.io/? It's a pretty mature service so I think it may be worth considering the benefit vs cost of this.

Do you think that having an interactive/runnable example is useful? I'd argue that yes (even though this page may not be the right one for it and it should go into the guides)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of in-person discussion with @lidel:
The main problem with embedding codesandbox is that it won't work when the page is loaded locally without an internet connection.

While that's true, I think the benefits of having these interactive examples outweigh the cost of them not working without internet connection.

@ElPaisano
Copy link
Contributor

@2color @lidel following up on this PR. Is this now addressed by merged PR #1476?
If so, could we close this? If not, lmk if you need content or a review or anything from me to help get it out

@2color
Copy link
Member Author

2color commented Mar 23, 2023

Yes. Let's close this since we already have the embed.

@2color 2color closed this Mar 23, 2023
@ElPaisano ElPaisano deleted the csb-cids branch April 6, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants