Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: cid conversion #734

Merged
merged 22 commits into from Apr 19, 2021
Merged

docs: cid conversion #734

merged 22 commits into from Apr 19, 2021

Conversation

lidel
Copy link
Member

@lidel lidel commented Apr 5, 2021

This PR adds basic docs about CID conversion (v0→v1, text→binary, and cid→hex).

Inspired by questions like multiformats/js-cid#142

This adds basic docs about CID conversion (v0→v1, and text→binary)
@lidel lidel requested review from BigLep and johnnymatthews Apr 5, 2021
Copy link
Contributor

@jessicaschilling jessicaschilling left a comment

Minor grammar/style nits. Thank you!

docs/concepts/content-addressing.md Outdated Show resolved Hide resolved
docs/concepts/content-addressing.md Outdated Show resolved Hide resolved
docs/concepts/content-addressing.md Outdated Show resolved Hide resolved
docs/concepts/content-addressing.md Outdated Show resolved Hide resolved
docs/concepts/content-addressing.md Outdated Show resolved Hide resolved
docs/concepts/content-addressing.md Outdated Show resolved Hide resolved
docs/concepts/content-addressing.md Outdated Show resolved Hide resolved
docs/concepts/glossary.md Outdated Show resolved Hide resolved
docs/concepts/glossary.md Outdated Show resolved Hide resolved
docs/concepts/glossary.md Outdated Show resolved Hide resolved
lidel and others added 19 commits Apr 6, 2021
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
@lidel lidel requested a review from jessicaschilling Apr 6, 2021
@lidel
Copy link
Member Author

lidel commented Apr 6, 2021

Applied style changes, thank you @jessicaschilling !

@johnnymatthews
Copy link
Collaborator

johnnymatthews commented Apr 19, 2021

Sorry for the delay on my end getting to this. Looks good! Merging in staging.

@johnnymatthews johnnymatthews changed the base branch from main to staging Apr 19, 2021
@johnnymatthews johnnymatthews merged commit d24bb05 into staging Apr 19, 2021
2 checks passed
@johnnymatthews johnnymatthews deleted the docs/cid-conversion branch Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants