New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to next AEgir #585

Merged
merged 4 commits into from Sep 4, 2017

Conversation

Projects
None yet
2 participants
@diasdavid
Member

diasdavid commented Aug 27, 2017

Updated deps and applied the same migrations that happen on the test repo with exception to the PubSub ones https://github.com/ipfs/aegir-test-repo/commit/75c82b3775db69a2e42d1005b767ef78e51161ea##commitcomment-23903275

Seeing a lot of errors coming from JEST, 94 tests fail out of 280.

@dignifiedquire

This comment has been minimized.

Show comment
Hide comment
@dignifiedquire

dignifiedquire Aug 27, 2017

Member

js-ipfs-api needs to run in --no-parallel mode because of the way test are set up currently.

Member

dignifiedquire commented Aug 27, 2017

js-ipfs-api needs to run in --no-parallel mode because of the way test are set up currently.

@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Aug 27, 2017

Member

Interesting. Ok added that and now I've multiple of one type of error:

Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
Member

diasdavid commented Aug 27, 2017

Interesting. Ok added that and now I've multiple of one type of error:

Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
@dignifiedquire

This comment has been minimized.

Show comment
Hide comment
@dignifiedquire

dignifiedquire Aug 27, 2017

Member

that means your tests are too slow and you have to increase the timeout for those

Member

dignifiedquire commented Aug 27, 2017

that means your tests are too slow and you have to increase the timeout for those

@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Aug 27, 2017

Member

Ok, updated all the timeouts for the tests that had timeouts. Now I've ECONRESET errors.

Member

diasdavid commented Aug 27, 2017

Ok, updated all the timeouts for the tests that had timeouts. Now I've ECONRESET errors.

@diasdavid diasdavid referenced this pull request Aug 27, 2017

Closed

new aegir #1

@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Aug 27, 2017

Member

Found that these problems also exist with the test repo, see ipfs/aegir-test-repo#1

Member

diasdavid commented Aug 27, 2017

Found that these problems also exist with the test repo, see ipfs/aegir-test-repo#1

@dignifiedquire

This comment has been minimized.

Show comment
Hide comment
@dignifiedquire

dignifiedquire Aug 27, 2017

Member

are you using all patches I made to ipfs-factory on the test repo?

Member

dignifiedquire commented Aug 27, 2017

are you using all patches I made to ipfs-factory on the test repo?

@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Aug 27, 2017

Member

@dignifiedquire see the PR ipfs/aegir-test-repo#1, it also fails there. I made no changes to the aegir-test-repo

Member

diasdavid commented Aug 27, 2017

@dignifiedquire see the PR ipfs/aegir-test-repo#1, it also fails there. I made no changes to the aegir-test-repo

@diasdavid diasdavid self-assigned this Aug 28, 2017

@diasdavid diasdavid referenced this pull request Aug 29, 2017

Merged

Adopt next aegir #961

@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Aug 29, 2017

Member

Seems that in CI most of the test suites are skipped:

image

VS local

image

Member

diasdavid commented Aug 29, 2017

Seems that in CI most of the test suites are skipped:

image

VS local

image

@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Aug 29, 2017

Member

nvm, seems that test count is correct, they just not get that pretty print

image

Member

diasdavid commented Aug 29, 2017

nvm, seems that test count is correct, they just not get that pretty print

image

@dignifiedquire

This comment has been minimized.

Show comment
Hide comment
@dignifiedquire

dignifiedquire Aug 29, 2017

Member

@diasdavid one lonely test failing on circle :D

Member

dignifiedquire commented Aug 29, 2017

@diasdavid one lonely test failing on circle :D

@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Aug 29, 2017

Member

@dignifiedquire gotta catch them all

Member

diasdavid commented Aug 29, 2017

@dignifiedquire gotta catch them all

@dignifiedquire

This comment has been minimized.

Show comment
Hide comment
@dignifiedquire

dignifiedquire Aug 29, 2017

Member

But travis is much slower and still timing out on tons of tests, plus it seems you haven't updated all files yet to pass linting

Member

dignifiedquire commented Aug 29, 2017

But travis is much slower and still timing out on tons of tests, plus it seems you haven't updated all files yet to pass linting

@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Aug 29, 2017

Member
  • update linting

Let's see now on another run :)

No worries here, I'll be following on this one

Member

diasdavid commented Aug 29, 2017

  • update linting

Let's see now on another run :)

No worries here, I'll be following on this one

@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Aug 30, 2017

Member

@dignifiedquire something is wrong with code coverage (last piece!)

https://travis-ci.org/ipfs/js-ipfs-api/jobs/269735569#L3113-L3166

Running locally I get nothing:

> ./node_modules/.bin/aegir codecov

> ./node_modules/.bin/aegir coveralls

Member

diasdavid commented Aug 30, 2017

@dignifiedquire something is wrong with code coverage (last piece!)

https://travis-ci.org/ipfs/js-ipfs-api/jobs/269735569#L3113-L3166

Running locally I get nothing:

> ./node_modules/.bin/aegir codecov

> ./node_modules/.bin/aegir coveralls

@dignifiedquire

This comment has been minimized.

Show comment
Hide comment
@dignifiedquire

dignifiedquire Aug 30, 2017

Member

seems your commands are wrong:

screen shot 2017-08-30 at 12 28 09

Member

dignifiedquire commented Aug 30, 2017

seems your commands are wrong:

screen shot 2017-08-30 at 12 28 09

@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Aug 30, 2017

Member

Seems that the default doesn't default

image

Also, running aegir coverage shouldn't require a provider if it isn't going to upload.

Member

diasdavid commented Aug 30, 2017

Seems that the default doesn't default

image

Also, running aegir coverage shouldn't require a provider if it isn't going to upload.

@dignifiedquire

This comment has been minimized.

Show comment
Hide comment
@dignifiedquire

dignifiedquire Aug 30, 2017

Member

@diasdavid I am confused about your statements

  • Uploading works fine to both providers as tested here: https://travis-ci.org/ipfs/aegir#L317
  • Uploading only happens if you pass the upload flag -u or --upload
  • There is no need to pass a provider if you are not using upload or at all if you are happy with the default
Member

dignifiedquire commented Aug 30, 2017

@diasdavid I am confused about your statements

  • Uploading works fine to both providers as tested here: https://travis-ci.org/ipfs/aegir#L317
  • Uploading only happens if you pass the upload flag -u or --upload
  • There is no need to pass a provider if you are not using upload or at all if you are happy with the default
@dignifiedquire

This comment has been minimized.

Show comment
Hide comment
@dignifiedquire

dignifiedquire Aug 30, 2017

Member

But I think I see that here is a bug with the aliasing, let me publish a release for that fix, that should solve the issue you are seeing

Member

dignifiedquire commented Aug 30, 2017

But I think I see that here is a bug with the aliasing, let me publish a release for that fix, that should solve the issue you are seeing

@dignifiedquire

This comment has been minimized.

Show comment
Hide comment
@dignifiedquire

dignifiedquire Aug 30, 2017

Member

published 12.0.1 please try that

Member

dignifiedquire commented Aug 30, 2017

published 12.0.1 please try that

@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Aug 31, 2017

Member

Ok, so now tests take over 40 mins to run in Travis (from previously 17 mins) plus they fail because it seems that npm run coverage interprets timeouts differently - https://travis-ci.org/ipfs/js-ipfs-api/jobs/270369029

Member

diasdavid commented Aug 31, 2017

Ok, so now tests take over 40 mins to run in Travis (from previously 17 mins) plus they fail because it seems that npm run coverage interprets timeouts differently - https://travis-ci.org/ipfs/js-ipfs-api/jobs/270369029

@dignifiedquire

This comment has been minimized.

Show comment
Hide comment
@dignifiedquire

dignifiedquire Aug 31, 2017

Member

@diasdavid well circle ci finally works. And it has much more reasonable build times which could probably be improved with setting up a parallel pipeline. As I mentioned in the community discussion, I think it is time for us to depart ways with travis

Member

dignifiedquire commented Aug 31, 2017

@diasdavid well circle ci finally works. And it has much more reasonable build times which could probably be improved with setting up a parallel pipeline. As I mentioned in the community discussion, I think it is time for us to depart ways with travis

@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Aug 31, 2017

Member

circle is not running Lint nor coverage

running coverage locally also fails and also takes a ton of extra time. I don't think we can blame travis on this one.

Member

diasdavid commented Aug 31, 2017

circle is not running Lint nor coverage

running coverage locally also fails and also takes a ton of extra time. I don't think we can blame travis on this one.

@dignifiedquire

This comment has been minimized.

Show comment
Hide comment
@dignifiedquire

dignifiedquire Aug 31, 2017

Member

Coverage is much slower than regular runs (always has been) because of the overhead of instrumentation. Not sure if there is some regression that jest is a lot slower for this though.

Member

dignifiedquire commented Aug 31, 2017

Coverage is much slower than regular runs (always has been) because of the overhead of instrumentation. Not sure if there is some regression that jest is a lot slower for this though.

@dignifiedquire

This comment has been minimized.

Show comment
Hide comment
@dignifiedquire

dignifiedquire Aug 31, 2017

Member

@diasdavid looking at travis output, it seems that the errors are actually not timeouts strange enough: https://travis-ci.org/ipfs/js-ipfs-api/jobs/270369040

Member

dignifiedquire commented Aug 31, 2017

@diasdavid looking at travis output, it seems that the errors are actually not timeouts strange enough: https://travis-ci.org/ipfs/js-ipfs-api/jobs/270369040

@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Aug 31, 2017

Member

image

It's always Timeout and then a cascade of failures

Member

diasdavid commented Aug 31, 2017

image

It's always Timeout and then a cascade of failures

@diasdavid diasdavid referenced this pull request Sep 4, 2017

Closed

⚡️ v0.26.0 RELEASE 🚀 #986

16 of 16 tasks complete
@dignifiedquire

This comment has been minimized.

Show comment
Hide comment
Member

dignifiedquire commented Sep 4, 2017

@dignifiedquire

This comment has been minimized.

Show comment
Hide comment
@dignifiedquire

dignifiedquire Sep 4, 2017

Member

@diasdavid coverage works now on circle, slow travis is still slow

Member

dignifiedquire commented Sep 4, 2017

@diasdavid coverage works now on circle, slow travis is still slow

@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Sep 4, 2017

Member

Thanks @dignifiedquire. I've mixed feelings about accepting our tests getting 2x or more slower due to JEST by just switching coverage to circle..

Just squashed commits and rebased master onto this branch, let's see what's left to do.

Member

diasdavid commented Sep 4, 2017

Thanks @dignifiedquire. I've mixed feelings about accepting our tests getting 2x or more slower due to JEST by just switching coverage to circle..

Just squashed commits and rebased master onto this branch, let's see what's left to do.

diasdavid added some commits Sep 4, 2017

@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Sep 4, 2017

Member
Test Node.js
 FAIL  test/interface/swarm.spec.js
  ● Test suite failed to run

    ENOENT: no such file or directory, open '/Users/imp/code/js-ipfs-api/node_modules/interface-ipfs-core/test/fixtures/testfile.txt'

      at Object.fs.openSync (fs.js:652:18)
      at Object.fs.readFileSync (fs.js:553:33)
      at loadFixtures (node_modules/aegir/src/fixtures.js:9:26)
      at Object.<anonymous> (node_modules/interface-ipfs-core/src/pin.js:12:18)
      at Object.<anonymous> (node_modules/interface-ipfs-core/src/index.js:6:15)

 FAIL  test/interface/pubsub.spec.js
  ● Test suite failed to run

    ENOENT: no such file or directory, open '/Users/imp/code/js-ipfs-api/node_modules/interface-ipfs-core/test/fixtures/testfile.txt'

      at Object.fs.openSync (fs.js:652:18)
      at Object.fs.readFileSync (fs.js:553:33)
      at loadFixtures (node_modules/aegir/src/fixtures.js:9:26)
      at Object.<anonymous> (node_modules/interface-ipfs-core/src/pin.js:12:18)
      at Object.<anonymous> (node_modules/interface-ipfs-core/src/index.js:6:15)

Needs: ipfs/interface-ipfs-core#154

Member

diasdavid commented Sep 4, 2017

Test Node.js
 FAIL  test/interface/swarm.spec.js
  ● Test suite failed to run

    ENOENT: no such file or directory, open '/Users/imp/code/js-ipfs-api/node_modules/interface-ipfs-core/test/fixtures/testfile.txt'

      at Object.fs.openSync (fs.js:652:18)
      at Object.fs.readFileSync (fs.js:553:33)
      at loadFixtures (node_modules/aegir/src/fixtures.js:9:26)
      at Object.<anonymous> (node_modules/interface-ipfs-core/src/pin.js:12:18)
      at Object.<anonymous> (node_modules/interface-ipfs-core/src/index.js:6:15)

 FAIL  test/interface/pubsub.spec.js
  ● Test suite failed to run

    ENOENT: no such file or directory, open '/Users/imp/code/js-ipfs-api/node_modules/interface-ipfs-core/test/fixtures/testfile.txt'

      at Object.fs.openSync (fs.js:652:18)
      at Object.fs.readFileSync (fs.js:553:33)
      at loadFixtures (node_modules/aegir/src/fixtures.js:9:26)
      at Object.<anonymous> (node_modules/interface-ipfs-core/src/pin.js:12:18)
      at Object.<anonymous> (node_modules/interface-ipfs-core/src/index.js:6:15)

Needs: ipfs/interface-ipfs-core#154

@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Sep 4, 2017

Member

Ok, some progress. Now it just crashes because...

image

Member

diasdavid commented Sep 4, 2017

Ok, some progress. Now it just crashes because...

image

@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Sep 4, 2017

Member

Travis go home, you are drunk.

Member

diasdavid commented Sep 4, 2017

Travis go home, you are drunk.

@diasdavid diasdavid merged commit 9ffe848 into master Sep 4, 2017

1 of 3 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details

@diasdavid diasdavid deleted the feat/aegir-next branch Sep 4, 2017

@dignifiedquire

This comment has been minimized.

Show comment
Hide comment
@dignifiedquire

dignifiedquire Sep 4, 2017

Member

woooooot it is merged 🎉

Member

dignifiedquire commented Sep 4, 2017

woooooot it is merged 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment