New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset batch size counter #175

Merged
merged 1 commit into from May 20, 2018

Conversation

Projects
None yet
3 participants
@vmx
Member

vmx commented May 18, 2018

When a batch of blocks was sent, the counter for the calculating
the size wasn't reset. After the initial batch, every message was
sent individually, which lead to a performance bottleneck. With
this change receiving larger files (> 2MiB) is about 30% faster.

fix: reset batch size counter
When a batch of blocks was sent, the counter for the calculating
the size wasn't reset. After the initial batch, every message was
sent individually, which lead to a performance bottleneck. With
this change receiving larger files (> 2MiB) is about 30% faster.

@vmx vmx requested review from dignifiedquire and daviddias May 18, 2018

@wafflebot wafflebot bot assigned vmx May 18, 2018

@wafflebot wafflebot bot added the in progress label May 18, 2018

@vmx vmx merged commit 739ad0d into master May 20, 2018

11 of 13 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
ci/circleci Your tests passed on CircleCI!
Details
ci/jenkins/codelint Linting passed
Details
ci/jenkins/commitlint Linting passed
Details
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/linux/8.11.1 Tests passed
Details
continuous-integration/jenkins/linux/9.2.0 Tests passed
Details
continuous-integration/jenkins/macos/8.11.1 Tests passed
Details
continuous-integration/jenkins/macos/9.2.0 Tests passed
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/jenkins/windows/8.11.1 Tests passed
Details
continuous-integration/jenkins/windows/9.2.0 Tests passed
Details

@wafflebot wafflebot bot removed the in progress label May 20, 2018

@vmx vmx deleted the fix-send-batches branch May 20, 2018

@dignifiedquire

This comment has been minimized.

Member

dignifiedquire commented May 22, 2018

thank you for catching this @vmx!

@daviddias daviddias referenced this pull request May 28, 2018

Closed

⚡️ v0.29.0 RELEASE 🚀 #1320

26 of 30 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment