New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reduce bundle size #186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hugomrdias I ran this against the js-ipfs core test suite npm run test:node:core
and there are failing tests. There may just need to be some tests updated there (for example I think some are checking the constructor name for numbers looking for 'Big', which is now BigNumber in repo tests), but we should make sure everything here is working properly before updating tests there.
73185b2
to
ca42d55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified this against js-ipfs as well. Aside from an existing error there, tests are passing.
this PR doesn't actually reduces repo bundle size but help a lot the top level repo like js-ipfs