This repository was archived by the owner on Aug 12, 2020. It is now read-only.
Fix the test #182
Merged
Fix the test #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The builder mutates the params you give it so you can no longer use the original to compare with the output.
The fix was to clone the input before passing to the builder. I would argue that it's mildly unexpected for the builder to mutate the input objects...perhaps the builder should be taking a clone of the inputs for it's own purposes? One for another PR?
Also, sorry sorry sorry - never change things after you run the tests and think "it'll be fine".
fixes #181