feat: pass in Options Object to http Constructor #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll have to forgive me, this is my first time contributing to IPFS. I'm not sure why Travis failed on this one. https://travis-ci.com/github/ipfs/js-ipfs-utils/jobs/320457226 I seem to be missing a subject and type, but I don't know where that would go. |
3 lines below there's a get help link |
It looks like the function was written to allow this as a parameter, but it was never used. This should allow for use cases like specifying custom headers while using `urlSource`. The `node-fetch` module falls back on [default options](https://github.com/node-fetch/node-fetch#options) if none are specified, so we shouldn't need to check and send an empty object at this step.
|
Thanks for the heads up, I hadn't seen the subject line section in the contributing guidelines. Should be good to go now. |
hugomrdias
changed the title
leoherzog
added a commit
to leoherzog/LinuxExchange
that referenced
this issue
May 2, 2020
leoherzog
added a commit
to leoherzog/LinuxExchangeIPFSSeedbox
that referenced
this issue
May 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
It looks like the function was written to allow this as a parameter, but it was never used. This should allow for use cases like specifying custom headers while using
urlSource. Thenode-fetchmodule falls back on default options if none are specified, so we shouldn't need to check and send an empty object at this step.