Already Piped #1446

agahEbrahimi · 2018-07-17T01:35:22Z

I have been attempting to work with ipfs-pubsub room but it randomly exits and gives this error. I have attempted the fixes in some issues on ipfs but they have not worked. Any ideas of how to fix it?

My ipfs version is the latest stable version.

These are the issues I am referring to:
https://github.com/libp2p/js-libp2p-switch/issues/235
#1156

This is the error:
throw new Error('already piped')
^

Error: already piped
    at sink (/Users/behrad/Desktop/ColIDE/JS/node_modules/pull-pair/index.js:11:13)
    at consume (/Users/behrad/Desktop/ColIDE/JS/node_modules/pull-defer/sink.js:7:17)
    at consume (/Users/behrad/Desktop/ColIDE/JS/node_modules/pull-defer/sink.js:7:17)
    at Connection.consume (/Users/behrad/Desktop/ColIDE/JS/node_modules/pull-defer/sink.js:7:17)
    at pull (/Users/behrad/Desktop/ColIDE/JS/node_modules/pull-stream/pull.js:43:9)
    at Dialer.handle (/Users/behrad/Desktop/ColIDE/JS/node_modules/multistream-select/src/dialer/index.js:47:5)
    at attemptMuxerUpgrade (/Users/behrad/Desktop/ColIDE/JS/node_modules/ipfs/node_modules/libp2p-switch/src/dial.js:157:10)
    at gotWarmedUpConn (/Users/behrad/Desktop/ColIDE/JS/node_modules/ipfs/node_modules/libp2p-switch/src/dial.js:54:7)
    at Switch.dial (/Users/behrad/Desktop/ColIDE/JS/node_modules/ipfs/node_modules/libp2p-switch/src/dial.js:40:9)
    at _getPeerInfo (/Users/behrad/Desktop/ColIDE/JS/node_modules/ipfs/node_modules/libp2p/src/index.js:237:19)

The text was updated successfully, but these errors were encountered:

justuswilhelm · 2018-07-17T09:28:23Z

Yes, I'm receiving the same error with the newest version 0.30.0:

Uncaught Error: already piped
    at sink (index.js:11)
    at consume (sink.js:7)
    at consume (sink.js:7)
    at Connection.consume (sink.js:7)
    at pull (pull.js:43)
    at Dialer.handle (index.js:47)
    at handleSafe (dial.js:51)
    at Dialer._attemptMuxerUpgrade (dial.js:249)
    at Dialer._createMuxedConnection (dial.js:214)
    at waterfall (dial.js:139)

alanshaw · 2018-07-17T14:53:07Z

@agahEbrahimi could you please upgrade to the latest js-ipfs? Your stack trace is referring to an old version of libp2p-switch.

@justuswilhelm a new version of libp2p-switch has been released if you do a fresh install of js-ipfs you should pick it up.

The new libp2p-switch has a fix for handling an error in the protocol handshake which might fix your issue. Please shout if you're still seeing the issue (with updated stacktrace plz!) and we'll investigate further.

agahEbrahimi · 2018-07-17T18:44:42Z

Thank you @alanshaw
That worked.

tyvdh · 2018-08-08T13:19:57Z

I'm still seeing this issue. All the latest versions of ipfs-js, orbitdb and libp2p-switch

Related. Context.
orbitdb/orbit-db#355 (comment)

/Users/tyler/Desktop/Web/Colorglyph-2.0/colorglyph-express/node_modules/pull-pair/index.js:11
      throw new Error('already piped')
      ^

Error: already piped
    at sink (/Users/tyler/Desktop/Web/Colorglyph-2.0/colorglyph-express/node_modules/pull-pair/index.js:11:13)
    at consume (/Users/tyler/Desktop/Web/Colorglyph-2.0/colorglyph-express/node_modules/pull-defer/sink.js:7:17)
    at consume (/Users/tyler/Desktop/Web/Colorglyph-2.0/colorglyph-express/node_modules/pull-defer/sink.js:7:17)
    at Connection.consume (/Users/tyler/Desktop/Web/Colorglyph-2.0/colorglyph-express/node_modules/pull-defer/sink.js:7:17)
    at pull (/Users/tyler/Desktop/Web/Colorglyph-2.0/colorglyph-express/node_modules/pull-stream/pull.js:43:9)
    at Dialer.handle (/Users/tyler/Desktop/Web/Colorglyph-2.0/colorglyph-express/node_modules/multistream-select/src/dialer/index.js:47:5)
    at handleSafe (/Users/tyler/Desktop/Web/Colorglyph-2.0/colorglyph-express/node_modules/libp2p-switch/src/dial.js:51:12)
    at Dialer._attemptMuxerUpgrade (/Users/tyler/Desktop/Web/Colorglyph-2.0/colorglyph-express/node_modules/libp2p-switch/src/dial.js:288:5)
    at Dialer._createMuxedConnection (/Users/tyler/Desktop/Web/Colorglyph-2.0/colorglyph-express/node_modules/libp2p-switch/src/dial.js:252:10)
    at waterfall (/Users/tyler/Desktop/Web/Colorglyph-2.0/colorglyph-express/node_modules/libp2p-switch/src/dial.js:139:14)
    at nextTask (/Users/tyler/Desktop/Web/Colorglyph-2.0/colorglyph-express/node_modules/async/waterfall.js:16:14)
    at next (/Users/tyler/Desktop/Web/Colorglyph-2.0/colorglyph-express/node_modules/async/waterfall.js:23:9)
    at /Users/tyler/Desktop/Web/Colorglyph-2.0/colorglyph-express/node_modules/async/internal/onlyOnce.js:12:16
    at Dialer._createBaseConnection (/Users/tyler/Desktop/Web/Colorglyph-2.0/colorglyph-express/node_modules/libp2p-switch/src/dial.js:185:14)
    at waterfall (/Users/tyler/Desktop/Web/Colorglyph-2.0/colorglyph-express/node_modules/libp2p-switch/src/dial.js:135:14)
    at nextTask (/Users/tyler/Desktop/Web/Colorglyph-2.0/colorglyph-express/node_modules/async/waterfall.js:16:14)

caffeinum · 2018-08-11T12:31:01Z

I have this issue too. We do use pubsub-room. I have the last versions of js-ipfs, libp2p and libp2p-switch(=0.40.7).

I wrote to this issue first: #1366 (comment)

th-ink · 2018-08-14T18:20:05Z

Can confirm I get the same issue as well, using libp2p-switch@0.40.7

/home/jwatts/node_modules/pull-pair/index.js:11
      throw new Error('already piped')
      ^

Error: already piped
    at sink (/home/jwatts/node_modules/pull-pair/index.js:11:13)
    at consume (/home/jwatts/node_modules/pull-defer/sink.js:7:17)
    at consume (/home/jwatts/node_modules/pull-defer/sink.js:7:17)
    at Connection.consume (/home/jwatts/node_modules/pull-defer/sink.js:7:17)
    at pull (/home/jwatts/node_modules/pull-stream/pull.js:43:9)
    at Dialer.handle (/home/jwatts/node_modules/multistream-select/src/dialer/index.js:47:5)
    at handleSafe (/home/jwatts/node_modules/libp2p-switch/src/dial.js:51:12)
    at Dialer._attemptMuxerUpgrade (/home/jwatts/node_modules/libp2p-switch/src/dial.js:288:5)
    at Dialer._createMuxedConnection (/home/jwatts/node_modules/libp2p-switch/src/dial.js:252:10)
    at waterfall (/home/jwatts/node_modules/libp2p-switch/src/dial.js:139:14)

jacobheun · 2018-08-15T11:26:17Z

The latest hotfix for multistream-select, 0.14.3, should prevent the error from being thrown. It will now be caught and logged. I will continue testing this to see if the issue comes up. Once you have multistream-select@0.14.3 (new installs should get it), if you do hit this issue, please scream in my general direction with logs and I will take a look!

Just fyi, I have been testing this against pubsub-room, along with a few other sample projects and the error is being logged properly.

th-ink · 2018-08-15T21:31:48Z

thanks @jacobheun, I can confirm that I don't get the error with multistream-select@0.14.3

mitra42 · 2018-08-16T00:58:28Z

How is multistream-select included, I'm not seeing (any version) in package-lock.json , and did a fresh install (from npm, not from github) yesterday.

jacobheun · 2018-08-16T03:48:17Z

It is used in libp2p (libp2p-switch and libp2p-circuit). npm ls should resolve it. I just did a fresh install from npm to verify.

└─┬ ipfs@0.31.4
  ├─┬ libp2p@0.23.1
  │ └─┬ libp2p-switch@0.40.7
  │   └── multistream-select@0.14.3  deduped
  └─┬ libp2p-circuit@0.2.1
    └── multistream-select@0.14.3

mitra42 · 2018-08-17T05:09:25Z

Confirmed - looks like I installed just before the release. I'll watch for the already piped errors (which I've been seeing regularly up till now)

alanshaw added kind/bug A bug in existing code (including security flaws) exp/expert Having worked on the specific codebase is important status/ready Ready to be worked P2 Medium: Good to have, but can wait until someone steps up labels Jul 17, 2018

jacobheun mentioned this issue Jul 17, 2018

Add better error handling around connection pulls (Already Piped, etc) multiformats/js-multistream-select#43

Closed

alanshaw closed this as completed Jul 18, 2018

ghost removed the status/ready Ready to be worked label Jul 18, 2018

alanshaw reopened this Aug 13, 2018

alanshaw mentioned this issue Aug 13, 2018

Already piped error prevents me to use IPFS #1502

Closed

daviddias added the status/ready Ready to be worked label Aug 13, 2018

Stebalien mentioned this issue Aug 13, 2018

Can go-ipfs be programmed or am I stuck with the CLI? ipfs/kubo#5377

Closed

jacobheun mentioned this issue Aug 14, 2018

fix: catch uncaught exceptions from pull in dialer.handle multiformats/js-multistream-select#44

Merged

noxonsu mentioned this issue Aug 15, 2018

Already Piped Error ipfs-shipyard/ipfs-pubsub-room#56

Open

alanshaw closed this as completed Sep 10, 2018

ghost removed the status/ready Ready to be worked label Sep 10, 2018

Already Piped #1446

Already Piped #1446

agahEbrahimi commented Jul 17, 2018

justuswilhelm commented Jul 17, 2018

alanshaw commented Jul 17, 2018

agahEbrahimi commented Jul 17, 2018

tyvdh commented Aug 8, 2018 •

edited

caffeinum commented Aug 11, 2018

th-ink commented Aug 14, 2018

jacobheun commented Aug 15, 2018

th-ink commented Aug 15, 2018

mitra42 commented Aug 16, 2018

jacobheun commented Aug 16, 2018

mitra42 commented Aug 17, 2018

Already Piped #1446

Already Piped #1446

Comments

agahEbrahimi commented Jul 17, 2018

justuswilhelm commented Jul 17, 2018

alanshaw commented Jul 17, 2018

agahEbrahimi commented Jul 17, 2018

tyvdh commented Aug 8, 2018 • edited

caffeinum commented Aug 11, 2018

th-ink commented Aug 14, 2018

jacobheun commented Aug 15, 2018

th-ink commented Aug 15, 2018

mitra42 commented Aug 16, 2018

jacobheun commented Aug 16, 2018

mitra42 commented Aug 17, 2018

tyvdh commented Aug 8, 2018 •

edited