New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awesome Endeavour - Correct libp2p-webrtc-star situation #981

Closed
diasdavid opened this Issue Sep 3, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@diasdavid
Member

diasdavid commented Sep 3, 2017

Following the ☕️💬 between @diasdavid and @lgierth https://github.com/ipfs/pm/pull/492/files#r136710447

  • libp2p-webrtc-star should encapsulate another multiaddr (as described in the issue) and that means that a /libp2p-webrtc-star/dns4/star-signal.cloud.ipfs.team/wss/ipfs/<your-peer-id> should in fact be /dns4/star-signal.cloud.ipfs.team/wss/libp2p-webrtc-star/ipfs/<your-peer-id>. This requires
    • Updating js-mafmt
    • Bubble up all the changes through the dep tree
  • Change libp2p-webrtc-star to p2p-webrtc-star (so that it matches the nomenclature also used by p2p-circuit)

@diasdavid diasdavid changed the title from Awesome Endeavour - Correct libp2p-webrtc-star addrs to Awesome Endeavour - Correct libp2p-webrtc-star situation Sep 3, 2017

diasdavid referenced this issue in ipfs/js-ipfs-bitswap Sep 3, 2017

@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Sep 3, 2017

Member

And with #984, this endeavor ends!

Member

diasdavid commented Sep 3, 2017

And with #984, this endeavor ends!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment