New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the welcome message and throw error when trying to cat a non-exis… #1032

Merged
merged 4 commits into from Oct 16, 2017

Conversation

Projects
None yet
3 participants
@atvanguard
Copy link
Contributor

atvanguard commented Oct 1, 2017

…tent file [Fixes #1031]

@dryajov

This comment has been minimized.

Copy link
Member

dryajov commented Oct 5, 2017

@atvanguard can you please add some tests verifying this works.

@atvanguard

This comment has been minimized.

Copy link
Contributor

atvanguard commented Oct 5, 2017

@dryajov Added. Let me know if something needs to be improved.

@daviddias

This comment has been minimized.

Copy link
Member

daviddias commented Oct 13, 2017

@atvanguard Looking good. Mind checking my comment? Otherwise, LGTM

@daviddias daviddias self-requested a review Oct 13, 2017

@daviddias
Copy link
Member

daviddias left a comment

Realized now that tests are failing. @atvanguard could you check that?

@atvanguard

This comment has been minimized.

Copy link
Contributor

atvanguard commented Oct 15, 2017

@diasdavid Incorporated the changes and increased the timeout for a test that was failing.

@daviddias
Copy link
Member

daviddias left a comment

Woot, thanks @atvanguard :)

@daviddias daviddias merged commit 25fb390 into ipfs:master Oct 16, 2017

3 checks passed

Node Security No known vulnerabilities found
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 84.659%
Details

@atvanguard atvanguard deleted the atvanguard:dev branch Oct 19, 2017

dryajov added a commit that referenced this pull request Oct 26, 2017

fix: fix the welcome message and throw error when trying to cat a non…
…-exis… (#1032)

* Fix the welcome message and throw error when trying to cat a non-existent file [Fixes #1031]

* Add tests

* Use CID instead of multihash, fix lint

* Increase cli init basic test timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment