Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use pull-mplex #1884

Merged
merged 1 commit into from May 8, 2019

Conversation

Projects
4 participants
@jacobheun
Copy link
Contributor

commented Feb 18, 2019

  • run ipfs/interop tests against this change

@ghost ghost assigned jacobheun Feb 18, 2019

@ghost ghost added the in progress label Feb 18, 2019

@jacobheun jacobheun force-pushed the feat/pull-mplex branch from d577d19 to 9df6fb0 Feb 20, 2019

@hugomrdias

This comment has been minimized.

Copy link
Collaborator

commented Apr 2, 2019

@jacobheun any chance i can help out with this ? this PR fixes vue support and protoschool

@jacobheun jacobheun force-pushed the feat/pull-mplex branch from f8c44e2 to f8222d8 Apr 2, 2019

@jacobheun

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

@hugomrdias i just rebased this with master so it has the latest updates. I have a WIP pr over at ipfs/interop#59 that I haven't been able to spend a ton of time on. I think this is in a good spot, but the interop tests have been unreliable as of late. It would be nice to get more deterministic results there.

@alanshaw

This comment has been minimized.

Copy link
Member

commented Apr 29, 2019

@jacobheun can we ship this? 🚢 😁 🙏

@jacobheun

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

@alanshaw not yet, ipfs/interop has an issue with pubsub I did not have a chance to look at last week. I will look into it more today/tomorrow.

@jacobheun jacobheun force-pushed the feat/pull-mplex branch from 700c296 to fc5bfac Apr 29, 2019

feat: use pull-mplex instead of libp2p-mplex
test: shut off dht by default

@jacobheun jacobheun force-pushed the feat/pull-mplex branch from fc5bfac to f6ec5e0 May 2, 2019

@jacobheun jacobheun changed the title [WIP] use pull-mplex feat: use pull-mplex May 6, 2019

@jacobheun jacobheun requested a review from alanshaw May 6, 2019

@jacobheun

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

The underlying issue with pubsub interop has been fixed, this is ready to go. You can see the passing interop tests at ipfs/interop#67.

@vasco-santos
Copy link
Member

left a comment

LGTM

@alanshaw alanshaw merged commit bd3ade6 into master May 8, 2019

4 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch 100% of diff hit (target 86.34%)
Details
codecov/project 86.36% (+0.01%) compared to f9bfa29
Details

@ghost ghost removed the in progress label May 8, 2019

@alanshaw alanshaw deleted the feat/pull-mplex branch May 8, 2019

@momack2 momack2 added this to Done in ipfs/js-ipfs May 10, 2019

@momack2 momack2 added this to Done in ipfs/js-waffle May 10, 2019

@alanshaw alanshaw referenced this pull request May 13, 2019

Closed

⚡️ v0.36.0 RELEASE 🚀 #2024

43 of 44 tasks complete

@jacobheun jacobheun referenced this pull request May 20, 2019

Open

Add to js-ipfs bundles #7

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.