From a88d22720729c8ecf7fab9fde869ff6be2ab5eb3 Mon Sep 17 00:00:00 2001 From: achingbrain Date: Tue, 31 Mar 2020 12:00:54 +0100 Subject: [PATCH 1/9] chore: be explicit about running interface tests Instead of running unit, interface, interface over http, etc tests in each build step, split the running of interface tests out into their own commands and run them independently on travis, hopefully the build should be a bit faster. --- .travis.yml | 20 ++++++++++++ packages/ipfs-http-client/.aegir.js | 10 +++--- packages/ipfs-http-client/package.json | 18 ++++++----- .../test/{interface.spec.js => interface.js} | 0 packages/ipfs/.aegir.js | 13 ++++---- packages/ipfs/package.json | 31 ++++++++++--------- packages/ipfs/test/http-api/index.js | 2 -- .../interface.js => interface-over-http.js} | 17 ++++++++-- ...interface.spec.js => interface-to-core.js} | 6 ++-- 9 files changed, 77 insertions(+), 40 deletions(-) rename packages/ipfs-http-client/test/{interface.spec.js => interface.js} (100%) rename packages/ipfs/test/{http-api/interface.js => interface-over-http.js} (85%) rename packages/ipfs/test/{core/interface.spec.js => interface-to-core.js} (95%) diff --git a/.travis.yml b/.travis.yml index 69f916f8df..07db16bcce 100644 --- a/.travis.yml +++ b/.travis.yml @@ -107,6 +107,26 @@ jobs: script: - npm run test:electron-renderer -- $RUN_SINCE -- -- --bail + - stage: test + name: interface to core - node + script: + - npm run test:interface:node -- $RUN_SINCE -- -- --bail + + - stage: test + name: interface to core - browser + script: + - npm run test:interface:browser -- $RUN_SINCE -- -- --bail + + - stage: test + name: interface over http - node + script: + - npm run test:interface:node:http -- $RUN_SINCE -- -- --bail + + - stage: test + name: interface over http - browser + script: + - npm run test:interface:browser:http -- $RUN_SINCE -- -- --bail + - stage: test name: interop - node script: diff --git a/packages/ipfs-http-client/.aegir.js b/packages/ipfs-http-client/.aegir.js index cbe19e93bc..a9ed44590f 100644 --- a/packages/ipfs-http-client/.aegir.js +++ b/packages/ipfs-http-client/.aegir.js @@ -38,9 +38,11 @@ module.exports = { hooks: { node: { pre: () => { - echoServer = EchoServer.createServer() + if (process.env.ECHO_SERVER_PORT) { + echoServer = EchoServer.createServer() - return echoServer.start() + return echoServer.start() + } }, post: () => echoServer.stop() }, @@ -50,13 +52,13 @@ module.exports = { return Promise.all([ server.start(), - echoServer.start() + echoServer ? echoServer.start() : null ]) }, post: () => { return Promise.all([ server.stop(), - echoServer.stop() + echoServer ? echoServer.stop() : null ]) } } diff --git a/packages/ipfs-http-client/package.json b/packages/ipfs-http-client/package.json index d01416dfea..c30de4ac66 100644 --- a/packages/ipfs-http-client/package.json +++ b/packages/ipfs-http-client/package.json @@ -23,14 +23,16 @@ "url": "git+https://github.com/ipfs/js-ipfs.git" }, "scripts": { - "test": "cross-env ECHO_SERVER_PORT=37490 aegir test", - "test:node": "cross-env ECHO_SERVER_PORT=37491 aegir test -t node", - "test:browser": "cross-env ECHO_SERVER_PORT=37492 aegir test -t browser", - "test:webworker": "cross-env ECHO_SERVER_PORT=37493 aegir test -t webworker", - "test:electron-main": "cross-env ECHO_SERVER_PORT=37494 aegir test -t electron-main", - "test:electron-renderer": "cross-env ECHO_SERVER_PORT=37495 aegir test -t electron-renderer", - "test:chrome": "cross-env ECHO_SERVER_PORT=37496 aegir test -t browser -t webworker -- --browsers ChromeHeadless", - "test:firefox": "cross-env ECHO_SERVER_PORT=37497 aegir test -t browser -t webworker -- --browsers FirefoxHeadless", + "test": "aegir test", + "test:node": "aegir test -t node", + "test:browser": "aegir test -t browser", + "test:webworker": "aegir test -t webworker", + "test:electron-main": "aegir test -t electron-main", + "test:electron-renderer": "aegir test -t electron-renderer", + "test:chrome": "aegir test -t browser -t webworker -- --browsers ChromeHeadless", + "test:firefox": "aegir test -t browser -t webworker -- --browsers FirefoxHeadless", + "test:interface:node:http": "cross-env ECHO_SERVER_PORT=37490 aegir test -t node -f test/interface.js", + "test:interface:browser:http": "cross-env ECHO_SERVER_PORT=37491 aegir test -t browser -f test/interface.js", "lint": "aegir lint", "build": "aegir build", "coverage": "npx nyc -r html npm run test:node -- --bail", diff --git a/packages/ipfs-http-client/test/interface.spec.js b/packages/ipfs-http-client/test/interface.js similarity index 100% rename from packages/ipfs-http-client/test/interface.spec.js rename to packages/ipfs-http-client/test/interface.js diff --git a/packages/ipfs/.aegir.js b/packages/ipfs/.aegir.js index 27ec0be6ac..6afb33b8c1 100644 --- a/packages/ipfs/.aegir.js +++ b/packages/ipfs/.aegir.js @@ -41,7 +41,10 @@ module.exports = { node: { pre: async () => { preloadNode = MockPreloadNode.createNode() - echoServer = EchoServer.createServer() + + if (process.env.ECHO_SERVER_PORT) { + echoServer = EchoServer.createServer() + } await preloadNode.start(), await echoServer.start() @@ -92,11 +95,9 @@ module.exports = { }).start() }, post: async () => { - await ipfsdServer.stop() - await preloadNode.stop() - await echoServer.stop() - await sigServerA.stop() - await sigServerB.stop() + await Promise.all( + [ipfsdServer, preloadNode, echoServer, sigServerA, sigServerB].map(server => server && server.stop()) + ) } } } diff --git a/packages/ipfs/package.json b/packages/ipfs/package.json index 20206468c6..9e6d26cb20 100644 --- a/packages/ipfs/package.json +++ b/packages/ipfs/package.json @@ -40,21 +40,22 @@ "scripts": { "lint": "aegir lint", "build": "aegir build", - "test": "cross-env ECHO_SERVER_PORT=37480 aegir test", - "test:node": "cross-env ECHO_SERVER_PORT=37481 aegir test -t node", - "test:browser": "cross-env ECHO_SERVER_PORT=37482 aegir test -t browser", - "test:browser:http": "cross-env ECHO_SERVER_PORT=37489 aegir test -t browser -f test/http-api/index.js", - "test:browser:interface:http": "cross-env ECHO_SERVER_PORT=37489 aegir test -t browser -f test/http-api/interface.js", - "test:webworker": "cross-env ECHO_SERVER_PORT=37483 aegir test -t webworker", - "test:electron": "cross-env ECHO_SERVER_PORT=37484 aegir test -t electron-main -t electron-renderer", - "test:electron-main": "cross-env ECHO_SERVER_PORT=37485 aegir test -t electron-main", - "test:electron-renderer": "cross-env ECHO_SERVER_PORT=37486 aegir test -t electron-renderer", - "test:cli": "cross-env ECHO_SERVER_PORT=37487 aegir test -t node -f test/cli/index.js", - "test:node:core": "cross-env ECHO_SERVER_PORT=37488 aegir test -t node -f test/core/**/*.js", - "test:node:http": "cross-env ECHO_SERVER_PORT=37489 aegir test -t node -f test/http-api/index.js", - "test:node:gateway": "cross-env ECHO_SERVER_PORT=37490 aegir test -t node -f test/gateway/index.js", - "test:node:interface": "cross-env ECHO_SERVER_PORT=37491 aegir test -t node -f test/core/interface.spec.js", - "test:bootstrapers": "cross-env ECHO_SERVER_PORT=37492 IPFS_TEST=bootstrapers aegir test -t browser -f test/bootstrapers.js", + "test": "aegir test", + "test:node": "aegir test -t node", + "test:browser": "aegir test -t browser", + "test:webworker": "aegir test -t webworker", + "test:electron": "aegir test -t electron-main -t electron-renderer", + "test:electron-main": "aegir test -t electron-main", + "test:electron-renderer": "aegir test -t electron-renderer", + "test:cli": "aegir test -t node -f test/cli/index.js", + "test:core": "aegir test -t node -f test/core/**/*.js", + "test:http": "aegir test -t node -f test/http-api/index.js", + "test:gateway": "aegir test -t node -f test/gateway/index.js", + "test:interface:node": "cross-env ECHO_SERVER_PORT=37491 aegir test -t node -f test/interface-to-core.js", + "test:interface:node:http": "cross-env ECHO_SERVER_PORT=37491 aegir test -t node -f test/interface-over-http.js", + "test:interface:browser": "cross-env ECHO_SERVER_PORT=37491 aegir test -t browser -f test/interface-to-core.js", + "test:interface:browser:http": "cross-env ECHO_SERVER_PORT=37489 aegir test -t browser -f test/interface-over-http.js", + "test:bootstrapers": "IPFS_TEST=bootstrapers aegir test -t browser -f test/bootstrapers.js", "test:interop": "cross-env IPFS_JS_EXEC=$PWD/src/cli/bin.js IPFS_JS_MODULE=$PWD IPFS_REUSEPORT=false ipfs-interop", "test:interop:node": "cross-env IPFS_JS_EXEC=$PWD/src/cli/bin.js IPFS_JS_MODULE=$PWD IPFS_REUSEPORT=false ipfs-interop -- -t node", "test:interop:browser": "cross-env IPFS_JS_EXEC=$PWD/src/cli/bin.js IPFS_JS_MODULE=$PWD IPFS_REUSEPORT=false ipfs-interop -- -t browser", diff --git a/packages/ipfs/test/http-api/index.js b/packages/ipfs/test/http-api/index.js index 8ee36db00d..a9380880a5 100644 --- a/packages/ipfs/test/http-api/index.js +++ b/packages/ipfs/test/http-api/index.js @@ -5,5 +5,3 @@ const { isNode } = require('ipfs-utils/src/env') if (isNode) { require('./routes') } - -require('./interface') diff --git a/packages/ipfs/test/http-api/interface.js b/packages/ipfs/test/interface-over-http.js similarity index 85% rename from packages/ipfs/test/http-api/interface.js rename to packages/ipfs/test/interface-over-http.js index 0905467848..d46503e5f3 100644 --- a/packages/ipfs/test/http-api/interface.js +++ b/packages/ipfs/test/interface-over-http.js @@ -2,8 +2,8 @@ 'use strict' const tests = require('interface-ipfs-core') -const factory = require('../utils/factory') -const { isNode } = require('ipfs-utils/src/env') +const factory = require('./utils/factory') +const { isNode, isBrowser } = require('ipfs-utils/src/env') /** @typedef { import("ipfsd-ctl").ControllerOptions } ControllerOptions */ describe('interface-ipfs-core over ipfs-http-client tests', function () { @@ -60,7 +60,18 @@ describe('interface-ipfs-core over ipfs-http-client tests', function () { sharding: true } } - })) + }), { + skip: isBrowser ? [{ + name: 'should make directory and specify mtime as hrtime', + reason: 'Not designed to run in the browser' + }, { + name: 'should write file and specify mtime as hrtime', + reason: 'Not designed to run in the browser' + }, { + name: 'should set mtime as hrtime', + reason: 'Not designed to run in the browser' + }] : [] + }) tests.key(commonFactory) diff --git a/packages/ipfs/test/core/interface.spec.js b/packages/ipfs/test/interface-to-core.js similarity index 95% rename from packages/ipfs/test/core/interface.spec.js rename to packages/ipfs/test/interface-to-core.js index 6abef6e66f..64b35b3619 100644 --- a/packages/ipfs/test/core/interface.spec.js +++ b/packages/ipfs/test/interface-to-core.js @@ -3,12 +3,14 @@ const tests = require('interface-ipfs-core') const { isNode } = require('ipfs-utils/src/env') -const factory = require('../utils/factory') +const factory = require('./utils/factory') /** @typedef { import("ipfsd-ctl").ControllerOptions } ControllerOptions */ describe('interface-ipfs-core tests', function () { - const commonFactory = factory() + const commonFactory = factory({ + type: 'proc' + }) tests.root(commonFactory, { skip: isNode ? null : [{ From 3ccdef8fee10478d01162e9b40e94c8bdffb2d90 Mon Sep 17 00:00:00 2001 From: achingbrain Date: Tue, 31 Mar 2020 13:46:17 +0100 Subject: [PATCH 2/9] chore: return resolved promise instead of null --- packages/ipfs-http-client/.aegir.js | 4 ++-- packages/ipfs/.aegir.js | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/ipfs-http-client/.aegir.js b/packages/ipfs-http-client/.aegir.js index a9ed44590f..6cbd4b8607 100644 --- a/packages/ipfs-http-client/.aegir.js +++ b/packages/ipfs-http-client/.aegir.js @@ -52,13 +52,13 @@ module.exports = { return Promise.all([ server.start(), - echoServer ? echoServer.start() : null + echoServer ? echoServer.start() : Promise.resolve() ]) }, post: () => { return Promise.all([ server.stop(), - echoServer ? echoServer.stop() : null + echoServer ? echoServer.stop() : Promise.resolve() ]) } } diff --git a/packages/ipfs/.aegir.js b/packages/ipfs/.aegir.js index 6afb33b8c1..5c4e0332dd 100644 --- a/packages/ipfs/.aegir.js +++ b/packages/ipfs/.aegir.js @@ -96,7 +96,9 @@ module.exports = { }, post: async () => { await Promise.all( - [ipfsdServer, preloadNode, echoServer, sigServerA, sigServerB].map(server => server && server.stop()) + [ipfsdServer, preloadNode, echoServer, sigServerA, sigServerB] + .filter(Boolean) + .map(server => server.stop()) ) } } From a5c5e45e34c2784dd05a0ce9423cd4b5d25c5adb Mon Sep 17 00:00:00 2001 From: achingbrain Date: Tue, 31 Mar 2020 14:08:35 +0100 Subject: [PATCH 3/9] chore: fix up aegir hooks --- packages/ipfs-http-client/.aegir.js | 10 +++++++--- packages/ipfs/.aegir.js | 19 ++++++++++++------- 2 files changed, 19 insertions(+), 10 deletions(-) diff --git a/packages/ipfs-http-client/.aegir.js b/packages/ipfs-http-client/.aegir.js index 6cbd4b8607..17d50c285b 100644 --- a/packages/ipfs-http-client/.aegir.js +++ b/packages/ipfs-http-client/.aegir.js @@ -37,14 +37,18 @@ module.exports = { }, hooks: { node: { - pre: () => { + pre: async () => { if (process.env.ECHO_SERVER_PORT) { echoServer = EchoServer.createServer() - return echoServer.start() + await echoServer.start() } }, - post: () => echoServer.stop() + post: async () => { + if (echoServer) { + await echoServer.stop() + } + } }, browser: { pre: () => { diff --git a/packages/ipfs/.aegir.js b/packages/ipfs/.aegir.js index 5c4e0332dd..82be6d8e40 100644 --- a/packages/ipfs/.aegir.js +++ b/packages/ipfs/.aegir.js @@ -44,23 +44,28 @@ module.exports = { if (process.env.ECHO_SERVER_PORT) { echoServer = EchoServer.createServer() + await echoServer.start() } - await preloadNode.start(), - await echoServer.start() + await preloadNode.start() }, post: async () => { - await preloadNode.stop(), - await echoServer.stop() + await preloadNode.stop() + + if (echoServer) { + await echoServer.stop() + } } }, browser: { pre: async () => { preloadNode = MockPreloadNode.createNode() - echoServer = EchoServer.createServer() - await preloadNode.start() - await echoServer.start() + if (process.env.ECHO_SERVER_PORT) { + echoServer = EchoServer.createServer() + await echoServer.start() + } + sigServerA = await webRTCStarSigServer.start({ host: '127.0.0.1', port: 14579, From 9684589fb7529aa9049da785cf501f3ab9c61735 Mon Sep 17 00:00:00 2001 From: achingbrain Date: Tue, 31 Mar 2020 14:50:57 +0100 Subject: [PATCH 4/9] chore: fix up more aegir hooks --- package.json | 4 ++++ packages/ipfs-http-client/.aegir.js | 24 +++++++++++++----------- 2 files changed, 17 insertions(+), 11 deletions(-) diff --git a/package.json b/package.json index 78c88e0d90..2e6adfaa61 100644 --- a/package.json +++ b/package.json @@ -13,6 +13,10 @@ "test:electron-main": "lerna run test:electron-main", "test:electron-renderer": "lerna run test:electron-renderer", "test:cli": "lerna run test:cli", + "test:interface:node": "lerna run test:interface:node", + "test:interface:node:http": "lerna run test:interface:node:http", + "test:interface:browser:http": "lerna run test:interface:browser:http", + "test:interface:browser": "lerna run test:interface:browser:http", "test:interop:node": "lerna run test:interop:node", "test:interop:browser": "lerna run test:interop:browser", "test:interop:electron-main": "lerna run test:interop:electron-main", diff --git a/packages/ipfs-http-client/.aegir.js b/packages/ipfs-http-client/.aegir.js index 17d50c285b..13f88bbc4e 100644 --- a/packages/ipfs-http-client/.aegir.js +++ b/packages/ipfs-http-client/.aegir.js @@ -51,19 +51,21 @@ module.exports = { } }, browser: { - pre: () => { - echoServer = EchoServer.createServer() + pre: async () => { + if (process.env.ECHO_SERVER_PORT) { + echoServer = EchoServer.createServer() + + await echoServer.start() + } - return Promise.all([ - server.start(), - echoServer ? echoServer.start() : Promise.resolve() - ]) + await server.start() }, - post: () => { - return Promise.all([ - server.stop(), - echoServer ? echoServer.stop() : Promise.resolve() - ]) + post: async () => { + if (echoServer) { + await echoServer.stop() + } + + await server.stop() } } } From 300c0179060534fa2f5e477c5557479f5dea2338 Mon Sep 17 00:00:00 2001 From: achingbrain Date: Tue, 31 Mar 2020 15:33:18 +0100 Subject: [PATCH 5/9] chore: more .aegir hook fixes --- packages/ipfs/.aegir.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/ipfs/.aegir.js b/packages/ipfs/.aegir.js index 82be6d8e40..ea5efdf67f 100644 --- a/packages/ipfs/.aegir.js +++ b/packages/ipfs/.aegir.js @@ -41,13 +41,12 @@ module.exports = { node: { pre: async () => { preloadNode = MockPreloadNode.createNode() + await preloadNode.start() if (process.env.ECHO_SERVER_PORT) { echoServer = EchoServer.createServer() await echoServer.start() } - - await preloadNode.start() }, post: async () => { await preloadNode.stop() @@ -60,6 +59,7 @@ module.exports = { browser: { pre: async () => { preloadNode = MockPreloadNode.createNode() + await preloadNode.start() if (process.env.ECHO_SERVER_PORT) { echoServer = EchoServer.createServer() From f54f0761f6a428bc5ea3d73d9bbe014e683f6275 Mon Sep 17 00:00:00 2001 From: achingbrain Date: Tue, 31 Mar 2020 16:24:22 +0100 Subject: [PATCH 6/9] chore: run interop tests against go and js in different jobs --- .travis.yml | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 07db16bcce..82092e41b4 100644 --- a/.travis.yml +++ b/.travis.yml @@ -118,14 +118,24 @@ jobs: - npm run test:interface:browser -- $RUN_SINCE -- -- --bail - stage: test - name: interface over http - node + name: interface over http to js-ipfs - node script: - - npm run test:interface:node:http -- $RUN_SINCE -- -- --bail + - npm run test:interface:node:http -- $RUN_SINCE --scope=ipfs -- -- --bail - stage: test - name: interface over http - browser + name: interface over http to js-ifps - browser script: - - npm run test:interface:browser:http -- $RUN_SINCE -- -- --bail + - npm run test:interface:browser:http -- $RUN_SINCE --scope=ipfs -- -- --bail + + - stage: test + name: interface over http to go-ifps - node + script: + - npm run test:interface:node:http -- $RUN_SINCE --scope=ipfs-http-client -- -- --bail + + - stage: test + name: interface over http to go-ipfs - browser + script: + - npm run test:interface:browser:http -- $RUN_SINCE --scope=ipfs-http-client -- -- --bail - stage: test name: interop - node From b3bbb381195b66df34353b76db59745a92a620fd Mon Sep 17 00:00:00 2001 From: achingbrain Date: Wed, 1 Apr 2020 14:42:17 +0100 Subject: [PATCH 7/9] fix: use correct config key --- packages/ipfs/package.json | 4 +++- packages/ipfs/src/cli/daemon.js | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/ipfs/package.json b/packages/ipfs/package.json index 9e6d26cb20..962083ac28 100644 --- a/packages/ipfs/package.json +++ b/packages/ipfs/package.json @@ -182,6 +182,7 @@ "clear-module": "^4.0.0", "cross-env": "^7.0.0", "delay": "^4.3.0", + "electron-webrtc": "^0.3.0", "execa": "^4.0.0", "form-data": "^3.0.0", "go-ipfs-dep": "0.4.23-3", @@ -199,7 +200,8 @@ "sinon": "^9.0.1", "stream-to-promise": "^2.2.0", "string-argv": "^0.3.1", - "temp-write": "^4.0.0" + "temp-write": "^4.0.0", + "wrtc": "^0.4.4" }, "optionalDependencies": { "prom-client": "^12.0.0", diff --git a/packages/ipfs/src/cli/daemon.js b/packages/ipfs/src/cli/daemon.js index 71654a6e93..3f3dc619d1 100644 --- a/packages/ipfs/src/cli/daemon.js +++ b/packages/ipfs/src/cli/daemon.js @@ -77,7 +77,7 @@ function getLibp2p ({ libp2pOptions, options, config, peerInfo }) { if (wrtc || electronWebRTC) { log(`Using ${wrtc ? 'wrtc' : 'electron-webrtc'} for webrtc support`) - set(libp2pOptions, 'config.transport.webRTCStar.wrtc', wrtc || electronWebRTC) + set(libp2pOptions, 'config.transport.WebRTCStar.wrtc', wrtc || electronWebRTC) libp2pOptions.modules.transport.push(WebRTCStar) } From 642f6780298972034d3c1ddb9b003f7777cc0824 Mon Sep 17 00:00:00 2001 From: achingbrain Date: Wed, 1 Apr 2020 15:08:47 +0100 Subject: [PATCH 8/9] chore: remove electron-wrtc --- .travis.yml | 2 +- packages/ipfs/package.json | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 82092e41b4..c80d38125b 100644 --- a/.travis.yml +++ b/.travis.yml @@ -64,7 +64,7 @@ jobs: - stage: check script: - npm run build -- $RUN_SINCE --scope={ipfs,ipfs-http-client} -- -- --bundlesize - - npm run dep-check -- $RUN_SINCE -- -- -- -i wrtc -i electron-webrtc + - npm run dep-check -- $RUN_SINCE -- -- -- -i electron-webrtc - npm run lint -- $RUN_SINCE --concurrency 1 - stage: test diff --git a/packages/ipfs/package.json b/packages/ipfs/package.json index 962083ac28..e1fcb254b6 100644 --- a/packages/ipfs/package.json +++ b/packages/ipfs/package.json @@ -182,7 +182,6 @@ "clear-module": "^4.0.0", "cross-env": "^7.0.0", "delay": "^4.3.0", - "electron-webrtc": "^0.3.0", "execa": "^4.0.0", "form-data": "^3.0.0", "go-ipfs-dep": "0.4.23-3", From 8aeca7e0ee7e7447df0355dcc0b56c281a9e2b54 Mon Sep 17 00:00:00 2001 From: achingbrain Date: Wed, 1 Apr 2020 15:40:00 +0100 Subject: [PATCH 9/9] chore: fix typo --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index c80d38125b..eb6c5ea2ac 100644 --- a/.travis.yml +++ b/.travis.yml @@ -123,12 +123,12 @@ jobs: - npm run test:interface:node:http -- $RUN_SINCE --scope=ipfs -- -- --bail - stage: test - name: interface over http to js-ifps - browser + name: interface over http to js-ipfs - browser script: - npm run test:interface:browser:http -- $RUN_SINCE --scope=ipfs -- -- --bail - stage: test - name: interface over http to go-ifps - node + name: interface over http to go-ipfs - node script: - npm run test:interface:node:http -- $RUN_SINCE --scope=ipfs-http-client -- -- --bail