This repository was archived by the owner on Feb 12, 2024. It is now read-only.
fix: fix ipfs config show #3067
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR `ipfs config show` work again and makes `config.get` first arg required
Member
|
Can we change the API to be something like: ipfs.config.getAll()
ipfs.config.get(key)instead of ipfs.config.get(undefined)
ipfs.config.get(key)Isomorphism in js is such a hack. |
Member
Author
|
Maybe |
Member
|
The CLI then literally shows the config though, which is not what we are doing, and the HTTP API is generated from the CLI commands. I think we can give the API commands more straightforward names, though they may call HTTP API endpoints that are named less descriptively. |
Member
|
Could do |
achingbrain
added a commit
that referenced
this pull request
Jun 5, 2020
Tactical fix to get the release out while we solve this properly in #3067
achingbrain
added a commit
that referenced
this pull request
Jun 5, 2020
Tactical fix to get the release out while we solve this properly in #3067
achingbrain
added a commit
that referenced
this pull request
Jun 5, 2020
Tactical fix to get the release out while we solve this properly in #3067
Member
Author
|
Makes sense, lets go with |
Member
Author
|
closed in favor of #3071 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
ipfs config showwork again andconfig.getfirst arg required.Also this makes ipfsd-ctl work again.