New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt next aegir #961

Merged
merged 11 commits into from Sep 8, 2017

Conversation

Projects
None yet
2 participants
@diasdavid
Member

diasdavid commented Aug 26, 2017

@dignifiedquire went ahead to try js-ipfs with next AEgir but started seeing some strange behaviors and errors. From what I can infer, the new AEgir doesn't like how interface spec tests are loaded by. See errors below:

 FAIL  test/core/interface/interface.spec.js (14.419s)
  ● Console

    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50209/ipfs/QmdQiFG5b3myVjxqT3R3kRYgXSNbBdt1uJtss8EQjLAUTC
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50210/ipfs/QmbMQ594mGbkQQD1Qy7tRwCgh3WV97zjRtXymFnUhWzDxp
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50211/ipfs/Qmf8DkFu7mV6ikxUhMYip1yjit9BhUkxmGW63pMPotPgdK
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50212/ipfs/QmWt8bnMs9RCkjCn6qzZM3GXAayQvdCY5VxqBHsPtFzBuc
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50214/ipfs/QmZdcZe4tkgjEhQpvFk3FBdqgDgvqBhP2RTeDUFZL36kmR
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50215/ipfs/QmSh3n1xmFS6ceCgtvXaPZM8Cq49tVocq1sxA9GePUoC3Z
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50216/ipfs/QmdWLvdsHkKehmdfq3dz9UKYW7Xs4xJjcBuTREeyoJ9gir
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50217/ipfs/QmeE7EEgDYyFsZ8SxdxN9STxRQCxvDaY7vuXE4HBiT3izc
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50221/ipfs/QmTo13pEYRiLjq4gc3uATFyEmKiBwXen9vnCqjHk1iDK5p
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50222/ipfs/QmRLZtQthQoXoyvaBYRVPf2SYnQZKasbvw4KWiZFtb1hae
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50223/ipfs/QmNXytQfEuEaLTmvWB45hYXGk23BUjZxwfdPgFMVFJqsJL
    console.log node_modules/interface-ipfs-core/src/pubsub.js:515
      Send/Receive 10k messages took: 3529 ms, 2833 ops / s

    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50244/ipfs/QmZijnvw9GoNQCnEWwyqYpRt4MDma8fjjLUTcR9YEPUa6U

  ● interface-ipfs-core tests › .files › encountered a declaration exception

    describe does not expect any arguments

      at Env.describe (node_modules/jest-jasmine2/build/jasmine/Env.js:299:15)
      at Suite.describe (node_modules/interface-ipfs-core/src/files.js:54:5)
      at Object.<anonymous>.module.exports [as files] (node_modules/interface-ipfs-core/src/files.js:20:3)
      at Object.<anonymous> (test/core/interface/files.js:19:6)

 PASS  test/core/create-node.spec.js (21.923s)
  ● Console

    console.log src/core/boot.js:82
      WARNING, trying to set config on uninitialized repo, maybe forgot to set "init: true"
    console.log src/core/boot.js:100
      WARNING, trying to start ipfs node on uninitialized repo, maybe forgot to set "init: true"
    console.log src/core/boot.js:82
      WARNING, trying to set config on uninitialized repo, maybe forgot to set "init: true"
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/9977/ipfs/QmbC8v1wp7aTyJk8aW2S4qtnFcY4KVpM6Y8grwWDSMEwpr

 FAIL  test/core/bitswap.spec.js (28.24s)
  ● Console

    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/50228/ipfs/QmUDuiRomnQrRW6KRAKRX2RkBwSjoSR1CaGCniL7jVzJNc

See how it is showing logs from PubSub tests and fails on the Files with an exception that is really unexpected: describe does not expect any arguments

Mind checking?

wip

@diasdavid diasdavid requested a review from dignifiedquire Aug 26, 2017

@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Aug 26, 2017

Member

I am in love with the new way of selecting targets and entry points for tests, great job! :D

Member

diasdavid commented Aug 26, 2017

I am in love with the new way of selecting targets and entry points for tests, great job! :D

@dignifiedquire

This comment has been minimized.

Show comment
Hide comment
@dignifiedquire

dignifiedquire Aug 26, 2017

Member

@diasdavid that error should have been fixed from this: ipfs/interface-ipfs-core#148 might be others around as well. Jest validates things a bit more strict than mocha

Member

dignifiedquire commented Aug 26, 2017

@diasdavid that error should have been fixed from this: ipfs/interface-ipfs-core#148 might be others around as well. Jest validates things a bit more strict than mocha

@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Aug 27, 2017

Member

Updated and released interface-ipfs-core to 0.31.2

Now seeing other errors:

  ● Console

    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/58556/ipfs/QmSXfXAtFagKbGp47fytiHtwAPDmDFxShNYLse7kG3gdWY
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/58557/ipfs/Qmexof9XeUaocH6QhgXQJCno4JebGZCSbJhpDGwsXQArce
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/58558/ipfs/QmYTWEiuGTcKJFuKsXPAA2Ffx35Gt4YykidmvMxQyAFJop
    console.error node_modules/jest-jasmine2/build/jasmine/Env.js:195
      Unhandled error
    console.error node_modules/jest-jasmine2/build/jasmine/Env.js:196
      Error: Unhandled "error" event. (Error: Non-base58 character)
          at Stream.emit (events.js:185:19)
          at next (/Users/imp/code/js-ipfs/node_modules/pull-stream-to-stream/index.js:117:13)
          at /Users/imp/code/js-ipfs/node_modules/pull-stream/throughs/map.js:19:9
          at /Users/imp/code/js-ipfs/node_modules/pull-stream/sources/error.js:5:5
          at /Users/imp/code/js-ipfs/node_modules/pull-stream/throughs/map.js:11:7
          at Immediate.drain [as _onImmediate] (/Users/imp/code/js-ipfs/node_modules/pull-stream-to-stream/index.js:108:5)
          at runCallback (timers.js:781:20)
          at tryOnImmediate (timers.js:743:5)
          at processImmediate [as _immediateCallback] (timers.js:714:5)
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/58559/ipfs/QmdGkRje1

and


  ● bitswap › connections › fetches a remote block › 2 peers

    data must be a buffer, was: {}

      at Object.add (node_modules/pull-reader/state.js:18:15)
      at node_modules/pull-reader/index.js:61:15
      at node_modules/pull-reader/index.js:20:7
      at WebSocket.<anonymous> (node_modules/pull-ws/source.js:23:14)
      at WebSocket.onMessage (node_modules/pull-ws/node_modules/ws/lib/WebSocket.js:442:14)
      at emitTwo (events.js:125:13)
      at WebSocket.emit (events.js:213:7)
      at Receiver.onbinary (node_modules/pull-ws/node_modules/ws/lib/WebSocket.js:848:10)
      at node_modules/pull-ws/node_modules/ws/lib/Receiver.js:628:18
      at Receiver.Object.<anonymous>.Receiver.applyExtensions (node_modules/pull-ws/node_modules/ws/lib/Receiver.js:371:5)

  ● bitswap › connections › fetches a remote block › 3 peers

    data must be a buffer, was: {}

      at Object.add (node_modules/pull-reader/state.js:18:15)
      at node_modules/pull-reader/index.js:61:15
      at node_modules/pull-reader/index.js:20:7
      at WebSocket.<anonymous> (node_modules/pull-ws/source.js:23:14)
      at WebSocket.onMessage (node_modules/pull-ws/node_modules/ws/lib/WebSocket.js:442:14)
      at emitTwo (events.js:125:13)
      at WebSocket.emit (events.js:213:7)
      at Receiver.onbinary (node_modules/pull-ws/node_modules/ws/lib/WebSocket.js:848:10)
      at node_modules/pull-ws/node_modules/ws/lib/Receiver.js:628:18
      at Receiver.Object.<anonymous>.Receiver.applyExtensions (node_modules/pull-ws/node_modules/ws/lib/Receiver.js:371:5)

  ● bitswap › connections › fetches a remote file › 2 peers

    data must be a buffer, was: {}

      at Object.add (node_modules/pull-reader/state.js:18:15)
      at node_modules/pull-reader/index.js:61:15
      at node_modules/pull-reader/index.js:20:7
Member

diasdavid commented Aug 27, 2017

Updated and released interface-ipfs-core to 0.31.2

Now seeing other errors:

  ● Console

    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/58556/ipfs/QmSXfXAtFagKbGp47fytiHtwAPDmDFxShNYLse7kG3gdWY
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/58557/ipfs/Qmexof9XeUaocH6QhgXQJCno4JebGZCSbJhpDGwsXQArce
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/58558/ipfs/QmYTWEiuGTcKJFuKsXPAA2Ffx35Gt4YykidmvMxQyAFJop
    console.error node_modules/jest-jasmine2/build/jasmine/Env.js:195
      Unhandled error
    console.error node_modules/jest-jasmine2/build/jasmine/Env.js:196
      Error: Unhandled "error" event. (Error: Non-base58 character)
          at Stream.emit (events.js:185:19)
          at next (/Users/imp/code/js-ipfs/node_modules/pull-stream-to-stream/index.js:117:13)
          at /Users/imp/code/js-ipfs/node_modules/pull-stream/throughs/map.js:19:9
          at /Users/imp/code/js-ipfs/node_modules/pull-stream/sources/error.js:5:5
          at /Users/imp/code/js-ipfs/node_modules/pull-stream/throughs/map.js:11:7
          at Immediate.drain [as _onImmediate] (/Users/imp/code/js-ipfs/node_modules/pull-stream-to-stream/index.js:108:5)
          at runCallback (timers.js:781:20)
          at tryOnImmediate (timers.js:743:5)
          at processImmediate [as _immediateCallback] (timers.js:714:5)
    console.log src/core/components/libp2p.js:50
      Swarm listening on /ip4/127.0.0.1/tcp/58559/ipfs/QmdGkRje1

and


  ● bitswap › connections › fetches a remote block › 2 peers

    data must be a buffer, was: {}

      at Object.add (node_modules/pull-reader/state.js:18:15)
      at node_modules/pull-reader/index.js:61:15
      at node_modules/pull-reader/index.js:20:7
      at WebSocket.<anonymous> (node_modules/pull-ws/source.js:23:14)
      at WebSocket.onMessage (node_modules/pull-ws/node_modules/ws/lib/WebSocket.js:442:14)
      at emitTwo (events.js:125:13)
      at WebSocket.emit (events.js:213:7)
      at Receiver.onbinary (node_modules/pull-ws/node_modules/ws/lib/WebSocket.js:848:10)
      at node_modules/pull-ws/node_modules/ws/lib/Receiver.js:628:18
      at Receiver.Object.<anonymous>.Receiver.applyExtensions (node_modules/pull-ws/node_modules/ws/lib/Receiver.js:371:5)

  ● bitswap › connections › fetches a remote block › 3 peers

    data must be a buffer, was: {}

      at Object.add (node_modules/pull-reader/state.js:18:15)
      at node_modules/pull-reader/index.js:61:15
      at node_modules/pull-reader/index.js:20:7
      at WebSocket.<anonymous> (node_modules/pull-ws/source.js:23:14)
      at WebSocket.onMessage (node_modules/pull-ws/node_modules/ws/lib/WebSocket.js:442:14)
      at emitTwo (events.js:125:13)
      at WebSocket.emit (events.js:213:7)
      at Receiver.onbinary (node_modules/pull-ws/node_modules/ws/lib/WebSocket.js:848:10)
      at node_modules/pull-ws/node_modules/ws/lib/Receiver.js:628:18
      at Receiver.Object.<anonymous>.Receiver.applyExtensions (node_modules/pull-ws/node_modules/ws/lib/Receiver.js:371:5)

  ● bitswap › connections › fetches a remote file › 2 peers

    data must be a buffer, was: {}

      at Object.add (node_modules/pull-reader/state.js:18:15)
      at node_modules/pull-reader/index.js:61:15
      at node_modules/pull-reader/index.js:20:7
@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Aug 27, 2017

Member

Browser tests are working fine in isolation

Member

diasdavid commented Aug 27, 2017

Browser tests are working fine in isolation

@dignifiedquire

This comment has been minimized.

Show comment
Hide comment
@dignifiedquire

dignifiedquire Aug 28, 2017

Member

maybe try no-parallel?

Member

dignifiedquire commented Aug 28, 2017

maybe try no-parallel?

@dignifiedquire

This comment has been minimized.

Show comment
Hide comment
@dignifiedquire

dignifiedquire Aug 29, 2017

Member

@diasdavid looking at these failures, they don't look related to aegir to me, rather than other things are actually broken

Member

dignifiedquire commented Aug 29, 2017

@diasdavid looking at these failures, they don't look related to aegir to me, rather than other things are actually broken

@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Aug 29, 2017

Member

Hm.. it might be that due to the new aegir, some things need to change, however, the tests do pass with old aegir. This is also happening with ipfs/js-ipfs-api#585 and even in the aegir-test-repo ipfs/aegir-test-repo#1 (comment) which suggests that it was not properly tested before the 12.0.0 release.

Let's figure out first in aegir test repo, then js-ipfs-api (which is very close) and then here. Probably fixing for one will fix for all anyway :)

Member

diasdavid commented Aug 29, 2017

Hm.. it might be that due to the new aegir, some things need to change, however, the tests do pass with old aegir. This is also happening with ipfs/js-ipfs-api#585 and even in the aegir-test-repo ipfs/aegir-test-repo#1 (comment) which suggests that it was not properly tested before the 12.0.0 release.

Let's figure out first in aegir test repo, then js-ipfs-api (which is very close) and then here. Probably fixing for one will fix for all anyway :)

@dignifiedquire

This comment has been minimized.

Show comment
Hide comment
@dignifiedquire

dignifiedquire Aug 29, 2017

Member

This might also indicate that some things were not being properly tested before and we have actual failures in these cases

Member

dignifiedquire commented Aug 29, 2017

This might also indicate that some things were not being properly tested before and we have actual failures in these cases

@diasdavid diasdavid referenced this pull request Sep 4, 2017

Closed

⚡️ v0.26.0 RELEASE 🚀 #986

16 of 16 tasks complete
@dignifiedquire

This comment has been minimized.

Show comment
Hide comment
@dignifiedquire
Member

dignifiedquire commented Sep 4, 2017

dignifiedquire added some commits Sep 5, 2017

Show outdated Hide outdated package.json
@dignifiedquire

This comment has been minimized.

Show comment
Hide comment
@dignifiedquire

dignifiedquire Sep 5, 2017

Member

Tests started working on circle now, due to the changes in the libp2p modules some hashes changed, (dag node protobuf orders the bytes a bit different now), but those fixes should be done independently

Member

dignifiedquire commented Sep 5, 2017

Tests started working on circle now, due to the changes in the libp2p modules some hashes changed, (dag node protobuf orders the bytes a bit different now), but those fixes should be done independently

@dignifiedquire

This comment has been minimized.

Show comment
Hide comment
@dignifiedquire
Member

dignifiedquire commented Sep 5, 2017

@diasdavid diasdavid changed the base branch from master to feat/aegir-next-2 Sep 8, 2017

@diasdavid diasdavid merged commit bffd1e5 into feat/aegir-next-2 Sep 8, 2017

1 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
ci/circleci A command timed out during your tests
Details
Node Security No known vulnerabilities found
Details

@diasdavid diasdavid deleted the feat/next-aegir branch Sep 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment