New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/bootstrapers gateway #975

Merged
merged 5 commits into from Sep 1, 2017

Conversation

Projects
None yet
1 participant
@diasdavid
Member

diasdavid commented Sep 1, 2017

applying #973

diasdavid added some commits Sep 1, 2017

@diasdavid

This comment has been minimized.

Show comment
Hide comment
@diasdavid

diasdavid Sep 1, 2017

Member

@VictorBjelkholm just discovered that the last PR introduced an issue for when multiaddrs are DNS. It seems that connectedAddr is coming as null and so any .toString on it fails.

This escaped because tests do not use DNS addrs.

The issue can be reproduced by running the tests, by running the exchange files example or by booting a node locally and running jsipfs swarm peers

Member

diasdavid commented Sep 1, 2017

@VictorBjelkholm just discovered that the last PR introduced an issue for when multiaddrs are DNS. It seems that connectedAddr is coming as null and so any .toString on it fails.

This escaped because tests do not use DNS addrs.

The issue can be reproduced by running the tests, by running the exchange files example or by booting a node locally and running jsipfs swarm peers

diasdavid added some commits Sep 1, 2017

@diasdavid diasdavid merged commit a15bee9 into master Sep 1, 2017

1 of 4 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Node Security No known vulnerabilities found
Details

@diasdavid diasdavid deleted the feat/bootstrapers-gateway branch Sep 1, 2017

@diasdavid diasdavid referenced this pull request Sep 11, 2017

Closed

⚡️ v0.26.0 RELEASE 🚀 #986

16 of 16 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment